Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exemplar support to CounterMetricFamily [Fix #1062] #1063

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add exemplar support to CounterMetricFamily [Fix #1062] #1063

merged 1 commit into from
Oct 14, 2024

Conversation

lod
Copy link
Contributor

@lod lod commented Oct 11, 2024

Fixes #1062

@lod
Add exemplar support to CounterMetricFamily
2aab8ac 
Fixes #1062

Signed-off-by: David Tulloh <git-david@tulloh.id.au>
csmarchbanks
csmarchbanks approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csmarchbanks csmarchbanks merged commit 37cd873 into prometheus:master Oct 14, 2024
11 checks passed
@lod lod deleted the fix/1062 branch October 15, 2024 23:22
@fcollonval fcollonval mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CounterMetricFamily should support exemplars
2 participants
@lod @csmarchbanks