Skip to content

Commit 8a24bde

Browse files
authored
Add abstract build method to MetricSnapshot.Builder (#969)
Signed-off-by: Mickael Maison <mickael.maison@gmail.com>
1 parent b2db709 commit 8a24bde

File tree

8 files changed

+10
-1
lines changed

8 files changed

+10
-1
lines changed

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/CounterSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ public Builder dataPoint(CounterDataPointSnapshot dataPoint) {
139139
return this;
140140
}
141141

142+
@Override
142143
public CounterSnapshot build() {
143144
return new CounterSnapshot(buildMetadata(), dataPoints);
144145
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/GaugeSnapshot.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,14 @@ private Builder() {
118118
}
119119

120120
/**
121-
* Add a data point. This can be alled multiple times to add multiple data points.
121+
* Add a data point. This can be called multiple times to add multiple data points.
122122
*/
123123
public Builder dataPoint(GaugeDataPointSnapshot dataPoint) {
124124
dataPoints.add(dataPoint);
125125
return this;
126126
}
127127

128+
@Override
128129
public GaugeSnapshot build() {
129130
return new GaugeSnapshot(buildMetadata(), dataPoints);
130131
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/HistogramSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ public Builder gaugeHistogram(boolean isGaugeHistogram) {
389389
return this;
390390
}
391391

392+
@Override
392393
public HistogramSnapshot build() {
393394
return new HistogramSnapshot(isGaugeHistogram, buildMetadata(), dataPoints);
394395
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/InfoSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ public Builder unit(Unit unit) {
9595
throw new IllegalArgumentException("Info metric cannot have a unit.");
9696
}
9797

98+
@Override
9899
public InfoSnapshot build() {
99100
return new InfoSnapshot(buildMetadata(), dataPoints);
100101
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/MetricSnapshot.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ public T unit(Unit unit) {
7676
return self();
7777
}
7878

79+
public abstract MetricSnapshot build();
80+
7981
protected MetricMetadata buildMetadata() {
8082
return new MetricMetadata(name, help, unit);
8183
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/StateSetSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ public Builder unit(Unit unit) {
219219
throw new IllegalArgumentException("StateSet metric cannot have a unit.");
220220
}
221221

222+
@Override
222223
public StateSetSnapshot build() {
223224
return new StateSetSnapshot(buildMetadata(), dataPoints);
224225
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/SummarySnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ public Builder dataPoint(SummaryDataPointSnapshot data) {
127127
return this;
128128
}
129129

130+
@Override
130131
public SummarySnapshot build() {
131132
return new SummarySnapshot(buildMetadata(), dataPoints);
132133
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/UnknownSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ public Builder dataPoint(UnknownDataPointSnapshot data) {
126126
return this;
127127
}
128128

129+
@Override
129130
public UnknownSnapshot build() {
130131
return new UnknownSnapshot(buildMetadata(), dataPoints);
131132
}

0 commit comments

Comments
 (0)