pr review

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Author: zeitlinger

.github/workflows/lint-rest.yml

@@ -22,9 +22,10 @@ jobs:
       - name: Remap main branch URLs to PR branch for link checking
         env:
           GITHUB_HEAD_REF: ${{ github.head_ref }}
+          PR_HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
         run: |
-          sed -i "/^remap = \[$/a\  \"https://github.com/prometheus/client_java/blob/main/(.*) https://github.com/prometheus/client_java/blob/${GITHUB_HEAD_REF}/\$1\"," .github/config/lychee.toml
-          sed -i "/^remap = \[$/a\  \"https://github.com/prometheus/client_java/tree/main/(.*) https://github.com/prometheus/client_java/tree/${GITHUB_HEAD_REF}/\$1\"," .github/config/lychee.toml
+          sed -i "/^remap = \[$/a\  \"https://github.com/prometheus/client_java/blob/main/(.*) https://github.com/${PR_HEAD_REPO}/blob/${GITHUB_HEAD_REF}/\$1\"," .github/config/lychee.toml
+          sed -i "/^remap = \[$/a\  \"https://github.com/prometheus/client_java/tree/main/(.*) https://github.com/${PR_HEAD_REPO}/tree/${GITHUB_HEAD_REF}/\$1\"," .github/config/lychee.toml
 
       - name: Lint for pull requests
         env:

docs/content/otel/jvm-runtime-metrics.md

@@ -96,9 +96,11 @@ OpenTelemetrySdk openTelemetry =
 RuntimeMetrics runtimeMetrics =
     RuntimeMetrics.builder(openTelemetry).build();
 
-// Close on shutdown to stop JMX metric collection
-Runtime.getRuntime()
-    .addShutdownHook(new Thread(runtimeMetrics::close));
+// Close on shutdown to stop metric collection and server
+Runtime.getRuntime().addShutdownHook(new Thread(() -> {
+  runtimeMetrics.close();
+  prometheusServer.close();
+}));
 
 // Scrape at http://localhost:9464/metrics
 ```

examples/example-otel-jvm-runtime-metrics/pom.xml

@@ -22,7 +22,7 @@
       <dependency>
         <groupId>io.opentelemetry.instrumentation</groupId>
         <artifactId>opentelemetry-instrumentation-bom-alpha</artifactId>
-        <version>2.24.0-alpha</version>
+        <version>${otel.instrumentation.version}</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>