Skip to content

Conversation

@saswatamcode
Copy link
Member

This PR adds an accepted message arg to NewHandler, to allow callers to limit what remote write messages their servers can handle.

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one suggestion only, map might be premature optimizations (for like 1 or 2 elements) (:

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@saswatamcode saswatamcode merged commit ad23ad6 into prometheus:main Feb 27, 2025
9 checks passed
ying-jeanne pushed a commit to ying-jeanne/client_golang that referenced this pull request Mar 28, 2025
* exp: Add accepted msg type validation to handler

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

* Apply feedback

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

---------

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants