Add exemplars for native histograms #1686

shivanthzen · 2024-11-17T19:31:28Z

Support exemplars in native histograms:
#1617

Remove unused variable fix tests Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

shivanthzen · 2025-01-14T14:56:47Z

@ArthurSens @beorn7 Part-2 for constnativehistogram support

bwplotka · 2025-01-20T09:22:42Z

Do you mind checking @beorn7 @ArthurSens ? I don't have context on this logic, not sure if this PR is what #1654 (comment) wanted.

beorn7 · 2025-01-21T13:29:35Z

This has been on my review list for a while. It's just hard to catch up through all my backlog… 😮‍💨

beorn7

I think this implements the intended idea. Thank you very much. However, I think we should also be able to handle a histogram with both native and classic buckets (even though we have no MustNewConst... constructor for it, but people could create it on their own using dto primitives). And we need to test that. See comments.

prometheus/metric.go

prometheus/metric_test.go

prometheus/metric.go

Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Shivanth MP <shivanth.metchem@deliveryhero.com>

shivanthzen · 2025-02-06T08:51:59Z

Update: This PR is still being worked on. Not stale.

beorn7 · 2025-02-06T11:49:42Z

@shivanthzen let us know when it is ready for the next round of review.

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

shivanthzen · 2025-04-15T09:16:39Z

@beorn7 Added a test to cover the case where exemplars are added to both buckets and exemplars.

beorn7

Thank you. I have just a naming nit and also just discovered that we need one small actual code change after all.

prometheus/metric_test.go

prometheus/metric.go

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/prometheus/client_golang](https://redirect.github.com/prometheus/client_golang) | `v1.22.0` -> `v1.23.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fclient_golang/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fclient_golang/v1.22.0/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.23.0`](https://redirect.github.com/prometheus/client_golang/releases/tag/v1.23.0): - 2025-07-30 [Compare Source](https://redirect.github.com/prometheus/client_golang/compare/v1.22.0...v1.23.0) - \[CHANGE] Minimum required Go version is now 1.23, only the two latest Go versions are supported from now on. [#1812](https://redirect.github.com/prometheus/client_golang/issues/1812) - \[FEATURE] Add WrapCollectorWith and WrapCollectorWithPrefix [#1766](https://redirect.github.com/prometheus/client_golang/issues/1766) - \[FEATURE] Add exemplars for native histograms [#1686](https://redirect.github.com/prometheus/client_golang/issues/1686) - \[ENHANCEMENT] exp/api: Bubble up status code from writeResponse [#1823](https://redirect.github.com/prometheus/client_golang/issues/1823) - \[ENHANCEMENT] collector/go: Update runtime metrics for Go v1.23 and v1.24 [#1833](https://redirect.github.com/prometheus/client_golang/issues/1833) - \[BUGFIX] exp/api: client prompt return on context cancellation [#1729](https://redirect.github.com/prometheus/client_golang/issues/1729) <details> <summary>All Changes</summary> * Update example test by @SuperQ in prometheus/client_golang#1770 * build(deps): bump golang.org/x/net from 0.34.0 to 0.36.0 in /tutorials/whatsup by @dependabot[bot] in prometheus/client_golang#1776 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1771 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1778 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1779 * build(deps): bump google.golang.org/protobuf from 1.36.5 to 1.36.6 in /exp by @dependabot[bot] in prometheus/client_golang#1782 * build(deps): bump github.com/prometheus/common from 0.62.0 to 0.63.0 in /exp by @dependabot[bot] in prometheus/client_golang#1781 * build(deps): bump github.com/prometheus/common from 0.62.0 to 0.63.0 by @dependabot[bot] in prometheus/client_golang#1783 * build(deps): bump google.golang.org/protobuf from 1.36.5 to 1.36.6 by @dependabot[bot] in prometheus/client_golang#1784 * build(deps): bump github.com/prometheus/procfs from 0.15.1 to 0.16.0 by @dependabot[bot] in prometheus/client_golang#1786 * chore: Upgrade golangci-lint to v2 by @kakkoyun in prometheus/client_golang#1789 * build(deps): bump the github-actions group across 1 directory with 3 updates by @dependabot[bot] in prometheus/client_golang#1790 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1791 * Add `WrapCollectorWith` and `WrapCollectorWithPrefix` by @colega in prometheus/client_golang#1766 * feat(github-actions): add Go file change detection to golangci-lint workflow by @kakkoyun in prometheus/client_golang#1794 * chore(ci): Fix flaky tests by @kakkoyun in prometheus/client_golang#1795 * build(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /tutorials/whatsup by @dependabot[bot] in prometheus/client_golang#1799 * test(registry): Add goleak-based goroutine leak detection by @surinkim in prometheus/client_golang#1797 * build(deps): bump go.uber.org/goleak from 1.2.0 to 1.3.0 by @dependabot[bot] in prometheus/client_golang#1806 * build(deps): bump the github-actions group with 2 updates by @dependabot[bot] in prometheus/client_golang#1804 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1809 * Add exemplars for native histograms by @shivanthzen in prometheus/client_golang#1686 * build(deps): bump golang.org/x/sys from 0.30.0 to 0.32.0 by @dependabot[bot] in prometheus/client_golang#1807 * build(deps): bump github.com/prometheus/client_model from 0.6.1 to 0.6.2 by @dependabot[bot] in prometheus/client_golang#1805 * build(deps): bump github.com/prometheus/procfs from 0.16.0 to 0.16.1 by @dependabot[bot] in prometheus/client_golang#1808 * build(deps): bump golang.org/x/net from 0.35.0 to 0.38.0 by @dependabot[bot] in prometheus/client_golang#1800 * Update supported Go versions by @SuperQ in prometheus/client_golang#1812 * Cleaup Go modules by @SuperQ in prometheus/client_golang#1813 * fix: client prompt return on context cancellation by @umegbewe in prometheus/client_golang#1729 * Simplify buf binary install by @SuperQ in prometheus/client_golang#1814 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1815 * build(deps): bump the github-actions group with 5 updates by @dependabot[bot] in prometheus/client_golang#1817 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1821 * exp/api: Bubble up status code from writeResponse by @saswatamcode in prometheus/client_golang#1823 * build(deps): bump github.com/prometheus/common from 0.64.0 to 0.65.0 by @dependabot[bot] in prometheus/client_golang#1827 * build(deps): bump github.com/prometheus/common from 0.64.0 to 0.65.0 in /exp by @dependabot[bot] in prometheus/client_golang#1828 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1831 * Update runtime metrics for Go v1.23 and v1.24 by @aknuds1 in prometheus/client_golang#1833 * Fix `errNotImplemented` reference by @aknuds1 in prometheus/client_golang#1835 * build(deps): bump the github-actions group with 3 updates by @dependabot[bot] in prometheus/client_golang#1826 * Synchronize common files from prometheus/prometheus by @prombot in prometheus/client_golang#1832 * Cut v1.23.0-rc.0 by @vesari in prometheus/client_golang#1837 * cut v1.23.0-rc.1 by @vesari in prometheus/client_golang#1842 </details> #### New Contributors * @surinkim made their first contributi[https://github.com/prometheus/client_golang/pull/1797](https://redirect.github.com/prometheus/client_golang/pull/1797)l/1797 * @umegbewe made their first contributi[https://github.com/prometheus/client_golang/pull/1729](https://redirect.github.com/prometheus/client_golang/pull/1729)l/1729 * @aknuds1 made their first contributi[https://github.com/prometheus/client_golang/pull/1833](https://redirect.github.com/prometheus/client_golang/pull/1833)l/1833 **Full Changelog**: https://github.com/prometheus/client\_golang/compare/v1.22.0...v1.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger).  Signed-off-by: Mend Renovate <bot@renovateapp.com>

Add exemplars for native histograms

6a6a456

Remove unused variable fix tests Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

shivanthzen force-pushed the nativehistogram_exemplars branch from 7569bb1 to 6a6a456 Compare January 4, 2025 20:34

shivanthzen marked this pull request as ready for review January 4, 2025 20:36

shivanthzen requested review from ArthurSens, bwplotka, kakkoyun and vesari as code owners January 4, 2025 20:36

shivanthzen marked this pull request as draft January 6, 2025 12:38

Merge branch 'main' into nativehistogram_exemplars

537b51f

shivanthzen marked this pull request as ready for review January 14, 2025 14:45

Add doc string for NewMetricWithExemplars

67dbd86

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

beorn7 requested changes Jan 21, 2025

View reviewed changes

prometheus/metric.go Outdated Show resolved Hide resolved

prometheus/metric_test.go Show resolved Hide resolved

prometheus/metric.go Outdated Show resolved Hide resolved

shivanthzen and others added 2 commits February 4, 2025 13:03

Update prometheus/metric.go

f799a31

Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Shivanth MP <shivanth.metchem@deliveryhero.com>

Update prometheus/metric.go

2ec9081

Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Shivanth MP <shivanth.metchem@deliveryhero.com>

shivanthzen added 2 commits April 14, 2025 23:16

Add more tests

6a3648e

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

nativehistogram exemplar test

7f9f76d

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

shivanthzen force-pushed the nativehistogram_exemplars branch from 951bff7 to 7f9f76d Compare April 14, 2025 21:17

Remove printlns

ca2462c

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

beorn7 requested changes Apr 15, 2025

View reviewed changes

prometheus/metric_test.go Outdated Show resolved Hide resolved

prometheus/metric.go Outdated Show resolved Hide resolved

shivanthzen added 4 commits April 16, 2025 22:27

Change the check for native histograms in proto

474af48

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

rename function

3940ed0

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

remove schema check

75e3d38

Signed-off-by: Shivanth <shivanth.metchem@deliveryhero.com>

Merge branch 'main' into nativehistogram_exemplars

e8f6d24

shivanthzen requested a review from beorn7 April 17, 2025 16:28

This was referenced Aug 1, 2025

deps: update module github.com/prometheus/client_golang to v1.23.0 hetznercloud/hcloud-cloud-controller-manager#991

Open

fix(deps): update module github.com/prometheus/client_golang to v1.23.0 prometheus-community/windows_exporter#2160

Merged

renovate-bot-for-keyhub bot mentioned this pull request Aug 2, 2025

fix(deps): update module github.com/prometheus/client_golang to v1.23.0 topicuskeyhub/keyhub-vault-operator#199

Open

1 task

cilium-renovate bot mentioned this pull request Aug 3, 2025

fix(deps): update all go dependencies main (main) cilium/cilium#40897

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add exemplars for native histograms #1686

Add exemplars for native histograms #1686

shivanthzen commented Nov 17, 2024 •

edited

Loading

Uh oh!

shivanthzen commented Jan 14, 2025 •

edited

Loading

Uh oh!

bwplotka commented Jan 20, 2025

Uh oh!

beorn7 commented Jan 21, 2025

Uh oh!

beorn7 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivanthzen commented Feb 6, 2025

Uh oh!

beorn7 commented Feb 6, 2025

Uh oh!

shivanthzen commented Apr 15, 2025

Uh oh!

beorn7 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add exemplars for native histograms #1686

Add exemplars for native histograms #1686

Conversation

shivanthzen commented Nov 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivanthzen commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bwplotka commented Jan 20, 2025

Uh oh!

beorn7 commented Jan 21, 2025

Uh oh!

beorn7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivanthzen commented Feb 6, 2025

Uh oh!

beorn7 commented Feb 6, 2025

Uh oh!

shivanthzen commented Apr 15, 2025

Uh oh!

beorn7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivanthzen commented Nov 17, 2024 •

edited

Loading

shivanthzen commented Jan 14, 2025 •

edited

Loading