Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get fails for xxhash/v2 #661

Closed
sepastian opened this issue Oct 17, 2019 · 3 comments
Closed

go get fails for xxhash/v2 #661

sepastian opened this issue Oct 17, 2019 · 3 comments

Comments

@sepastian
Copy link

I am following the guide for client_golang: https://prometheus.io/docs/guides/go-application/

Installing promhttp with go get fails because of an invalid dependency on xxhash/v2.

$ go get github.com/prometheus/client_golang/prometheus/promhttp
package github.com/cespare/xxhash/v2: cannot find package "github.com/cespare/xxhash/v2" in any of:
	/home/sebastian/.asdf/installs/golang/1.10/go/src/github.com/cespare/xxhash/v2 (from $GOROOT)
	/home/sebastian/Code/sipts/worker-base/src/github.com/cespare/xxhash/v2 (from $GOPATH)

$ go version
go version go1.10 linux/amd64

The URL https://github.com/cespare/xxhash/v2 is invalid; should this read https://github.com/cespare/xxhash/tree/v2 instead?

@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

This is a change introduced by go modules. To make it work with older Go versions, those got patched. You need to run go go 1.10.3+.

I'll add that to the README.md.

@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

Now addressed in README.md.

@beorn7 beorn7 closed this as completed Oct 17, 2019
@sepastian
Copy link
Author

I tried with go 1.13.1 yesterday, it works there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants