fix(env): Remove deprecated auto-gomaxprocs flag#5251
Conversation
The `auto-gomaxprocs` flag was deprecated in v0.32. It has had no effect since v0.29, when we moved to Go 1.25, which natively handles container CPU quotas without the need for the automaxprocs library. See https://go.dev/blog/container-aware-gomaxprocs Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes the deprecated ChangesRemove auto-gomaxprocs feature flag
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
auto-gomaxprocsflag was deprecated in v0.32. It has had no effectsince v0.29, when we moved to Go 1.25, which natively handles container
CPU quotas without the need for the automaxprocs library.
See https://go.dev/blog/container-aware-gomaxprocs
Signed-off-by: Solomon Jacobs solomonjacobs@protonmail.com
Pull Request Checklist
Yes.
Which user-facing changes does this PR introduce?
Summary by CodeRabbit
auto-gomaxprocsfeature flag and associated startup deprecation warnings.