Skip to content

Commit 93c6ea4

Browse files
committed
address review feedback
1 parent 119e1c4 commit 93c6ea4

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

api/v1_deprecation_router.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,13 @@ func (dr *V1DeprecationRouter) deprecationHandler(w http.ResponseWriter, req *ht
5555
Error string `json:"error"`
5656
}{
5757
"deprecated",
58-
"The Alertmanager v1 API was deprecated in version 0.16.0 and entirely removed since version 0.28.0 - please use the equivalent route in the v2 API",
58+
"The Alertmanager v1 API was deprecated in version 0.16.0 and is removed as of version 0.28.0 - please use the equivalent route in the v2 API",
5959
}
6060

6161
w.Header().Set("Content-Type", "application/json")
6262
w.WriteHeader(410)
6363

64-
// We don't care about errors for this route.
65-
b, _ := json.Marshal(resp)
66-
67-
if _, err := w.Write(b); err != nil {
68-
level.Error(dr.logger).Log("msg", "failed to write data to connection", "err", err)
64+
if err := json.NewEncoder(w).Encode(resp); err != nil {
65+
level.Error(dr.logger).Log("msg", "failed to write response", "err", err)
6966
}
7067
}

0 commit comments

Comments
 (0)