Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanos: bump to latest and add thanosPrometheusCommonDimensions #1399

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

arajkumar
Copy link
Contributor

Description

This commit pulls latest changes from thanos mixins and sets thanosPrometheusCommonDimensions
to namespace, pod for k8s use case.

Refer thanos-io/thanos#4508 for more details.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.


Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com

This commit pulls latest changes from thanos mixins and sets `thanosPrometheusCommonDimensions`
to `namespace, pod` for k8s use case.

Refer thanos-io/thanos#4508 for more details.

Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgrisonnet dgrisonnet merged commit f16bb13 into prometheus-operator:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants