Skip to content

Commit eb8886b

Browse files
committed
Fixed 9 metric type misclassifications in IIS collectors
1 parent 370a42b commit eb8886b

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

internal/collector/iis/iis_app_pool_was.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ func (c *Collector) collectAppPoolWAS(ch chan<- prometheus.Metric) error {
239239

240240
ch <- prometheus.MustNewConstMetric(
241241
c.totalApplicationPoolUptime,
242-
prometheus.CounterValue,
242+
prometheus.GaugeValue,
243243
data.TotalApplicationPoolUptime,
244244
data.Name,
245245
)

internal/collector/iis/iis_http_service_request_queues.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func (c *Collector) collectHttpServiceRequestQueues(ch chan<- prometheus.Metric)
113113

114114
ch <- prometheus.MustNewConstMetric(
115115
c.httpRequestQueuesTotalRejectedRequest,
116-
prometheus.GaugeValue,
116+
prometheus.CounterValue,
117117
data.HttpRequestQueuesTotalRejectedRequests,
118118
data.Name,
119119
)

internal/collector/iis/iis_w3svc_w3wp.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -366,25 +366,25 @@ func (c *Collector) buildW3SVCW3WP() error {
366366
)
367367
c.w3SVCW3WPWebSocketRequestsActive = prometheus.NewDesc(
368368
prometheus.BuildFQName(types.Namespace, Name, "worker_current_websocket_requests"),
369-
"",
369+
"Current number of active WebSocket requests in the worker process",
370370
[]string{"app", "pid"},
371371
nil,
372372
)
373373
c.w3SVCW3WPWebSocketConnectionAttempts = prometheus.NewDesc(
374-
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_attempts_total"),
375-
"",
374+
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_attempts_per_sec"),
375+
"WebSocket connection attempts per second",
376376
[]string{"app", "pid"},
377377
nil,
378378
)
379379
c.w3SVCW3WPWebSocketConnectionsAccepted = prometheus.NewDesc(
380-
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_accepted_total"),
381-
"",
380+
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_accepted_per_sec"),
381+
"WebSocket connections accepted per second",
382382
[]string{"app", "pid"},
383383
nil,
384384
)
385385
c.w3SVCW3WPWebSocketConnectionsRejected = prometheus.NewDesc(
386-
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_rejected_total"),
387-
"",
386+
prometheus.BuildFQName(types.Namespace, Name, "worker_websocket_connection_rejected_per_sec"),
387+
"WebSocket connections rejected per second",
388388
[]string{"app", "pid"},
389389
nil,
390390
)
@@ -471,31 +471,31 @@ func (c *Collector) collectW3SVCW3WPv8(ch chan<- prometheus.Metric) error {
471471

472472
ch <- prometheus.MustNewConstMetric(
473473
c.w3SVCW3WPWebSocketRequestsActive,
474-
prometheus.CounterValue,
474+
prometheus.GaugeValue,
475475
data.W3SVCW3WPWebSocketRequestsActive,
476476
name,
477477
pid,
478478
)
479479

480480
ch <- prometheus.MustNewConstMetric(
481481
c.w3SVCW3WPWebSocketConnectionAttempts,
482-
prometheus.CounterValue,
482+
prometheus.GaugeValue,
483483
data.W3SVCW3WPWebSocketConnectionAttempts,
484484
name,
485485
pid,
486486
)
487487

488488
ch <- prometheus.MustNewConstMetric(
489489
c.w3SVCW3WPWebSocketConnectionsAccepted,
490-
prometheus.CounterValue,
490+
prometheus.GaugeValue,
491491
data.W3SVCW3WPWebSocketConnectionsAccepted,
492492
name,
493493
pid,
494494
)
495495

496496
ch <- prometheus.MustNewConstMetric(
497497
c.w3SVCW3WPWebSocketConnectionsRejected,
498-
prometheus.CounterValue,
498+
prometheus.GaugeValue,
499499
data.W3SVCW3WPWebSocketConnectionsRejected,
500500
name,
501501
pid,
@@ -539,7 +539,7 @@ func (c *Collector) collectW3SVCW3WPv7(ch chan<- prometheus.Metric) error {
539539

540540
ch <- prometheus.MustNewConstMetric(
541541
c.w3SVCW3WPMaximumThreads,
542-
prometheus.CounterValue,
542+
prometheus.GaugeValue,
543543
data.W3SVCW3WPMaximumThreads,
544544
name,
545545
pid,
@@ -555,7 +555,7 @@ func (c *Collector) collectW3SVCW3WPv7(ch chan<- prometheus.Metric) error {
555555

556556
ch <- prometheus.MustNewConstMetric(
557557
c.w3SVCW3WPRequestsActive,
558-
prometheus.CounterValue,
558+
prometheus.GaugeValue,
559559
data.W3SVCW3WPRequestsActive,
560560
name,
561561
pid,
@@ -579,7 +579,7 @@ func (c *Collector) collectW3SVCW3WPv7(ch chan<- prometheus.Metric) error {
579579

580580
ch <- prometheus.MustNewConstMetric(
581581
c.w3SVCW3WPMaximumFileCacheMemoryUsage,
582-
prometheus.CounterValue,
582+
prometheus.GaugeValue,
583583
data.W3SVCW3WPMaximumFileCacheMemoryUsage,
584584
name,
585585
pid,

0 commit comments

Comments
 (0)