Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths in package.json don't exist #20

Closed
arendjr opened this issue Oct 21, 2020 · 4 comments
Closed

Paths in package.json don't exist #20

arendjr opened this issue Oct 21, 2020 · 4 comments

Comments

@arendjr
Copy link
Contributor

arendjr commented Oct 21, 2020

The project's package.json refers to lib/index.js and lib/index.d.ts, but these files don't exist in the package as published to NPM. It seems this is not a problem for Webpack and TypeScript, which will fall back to the default index.js and index.d.ts in the root of the project, where they do exist. However, other tools such as Snowpack, which appear to be more strict with this do struggle because of this.

@celian-garcia
Copy link
Contributor

Hello @arendjr, thanks for the contribution. I'm having a look

@celian-garcia
Copy link
Contributor

Ah yes ! you are right we publish the content of lib folder 😄 sorry for that I accept the PR, and I will release a 1.6.1 today.

@celian-garcia
Copy link
Contributor

1.6.1 released successfully, it should be available soon https://www.npmjs.com/package/monaco-promql

@arendjr
Copy link
Contributor Author

arendjr commented Oct 22, 2020

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants