Add support for HTTP POST body content
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
SuperQ
reviewed
Oct 2, 2021
exporter/util.go
Outdated
Comment on lines
128
to
144
| br := strings.NewReader(c.Body.Content) | ||
| if c.Body.Templatize { | ||
| tpl, err := template.New("base").Funcs(sprig.GenericFuncMap()).Parse(c.Body.Content) | ||
| if err != nil { | ||
|
|
||
| level.Error(logger).Log("msg", "Failed to create a new template from body content", "err", err, "content", c.Body.Content) //nolint:errcheck | ||
| } | ||
| var b strings.Builder | ||
| if err := tpl.Execute(&b, tplValues); err != nil { | ||
| level.Error(logger).Log("msg", "Failed to render template with values", "err", err, "tempalte", c.Body.Content) //nolint:errcheck | ||
|
|
||
| // `tplValues` can contain sensitive values, so log it only when in debug mode | ||
| level.Debug(logger).Log("msg", "Failed to render template with values", "err", err, "tempalte", c.Body.Content, "values", tplValues) //nolint:errcheck | ||
| } | ||
| br = strings.NewReader(b.String()) | ||
| } | ||
| req, err = http.NewRequest("POST", endpoint, br) |
There was a problem hiding this comment.
This would be a little cleaner as a separate function, rather than all inline.
Something like this:
func renderBody(c ConfigBody, tplValues url.Values) (io.Reader, error) {...}
There was a problem hiding this comment.
I have refactored it into a separate function now.
SuperQ
reviewed
Oct 2, 2021
Signed-off-by: rustyclock <rustyclock@protonmail.com>
SuperQ
added a commit
that referenced
this pull request
Jan 15, 2022
* [FEATURE] Add support for HTTP POST body content #123 Signed-off-by: SuperQ <superq@gmail.com>
Merged
rustycl0ck
pushed a commit
that referenced
this pull request
Jan 18, 2022
* [FEATURE] Add support for HTTP POST body content #123 Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #69