Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-adapter] bugfix psp port range #135

Merged
merged 9 commits into from
Sep 23, 2020
Merged

[prometheus-adapter] bugfix psp port range #135

merged 9 commits into from
Sep 23, 2020

Conversation

ahmednasir91
Copy link
Contributor

What this PR does / why we need it:

Fixes the bug in prometheus adapter psp where the port range defined was incorrect max > min.

 Error: cannot patch "prometheus-adapter" with kind PodSecurityPolicy: PodSecurityPolicy.extensions "prometheus-adapter" is invalid: spec.runAsUser.ranges[0].min: Invalid value: 65535: min cannot be greater than max

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@ahmednasir91
[prometheus-adapter] added psp for prometheus adapter
609c341 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
added newline to the psp file.
079ecf3 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
bumped chart version
c014be7 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
review feedback, changes in ranges
bcb980d 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
[prometheus-adapter] psp run as user ranggevalues min and max
045d4e5 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
merge
5c4d642 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
fix merge conflict
f64d8e0 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91 ahmednasir91 mentioned this pull request Sep 23, 2020
Merged
3 tasks
steven-sheehy
steven-sheehy previously approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to re-bump

@ahmednasir91
bump version
47d480a 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@ahmednasir91
Copy link
Contributor Author

@steven-sheehy bumped

@ahmednasir91
merge conflict
56b7a63 
Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
@steven-sheehy steven-sheehy merged commit 5b25a9b into prometheus-community:main Sep 23, 2020
monotek pushed a commit to monotek/prometheus-helm-charts that referenced this pull request Oct 7, 2020
@ahmednasir91
[prometheus-adapter] bugfix psp port range (prometheus-community#135)
a904cb4 
Fix the bug in prometheus adapter psp where the port range defined was incorrect max > min.

Signed-off-by: Ahmed Nasir <ahmednasir91@gmail.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@hectorj2f hectorj2f Awaiting requested review from hectorj2f hectorj2f is a code owner

@MattiasGees MattiasGees Awaiting requested review from MattiasGees MattiasGees is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmednasir91 @steven-sheehy