Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-redis-exporter] Allow setting namespace for redis-exporter deployment #3903

Open
nikochiko opened this issue Oct 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nikochiko
Copy link

Is your feature request related to a problem ?

prometheus-redis-exporter's deployment has no way to set the namespace (

metadata:
name: {{ template "prometheus-redis-exporter.fullname" . }}
labels:
{{ include "prometheus-redis-exporter.labels" . | indent 4 }}
annotations:
).

The related service monitor's namespace can be set with Values.serviceMonitor.namespace but not for the deployment.

This is a problem because my Helm chart is installed with a monitoring namespace, but I want the deployment for redis-exporter to be created in the same namespace as the Redis pods -- for sharing secrets.

Describe the solution you'd like.

The redis-exporter deployment should respect Values.namespace (a key that doesn't exist yet).

It would also make sense for this key to be the default for the related serviceMonitor unless Values.serviceMonitor.namespace is explicitly provided.

Describe alternatives you've considered.

NONE

Additional context.

I can contribute the needed change for this.

@nikochiko nikochiko added the enhancement New feature or request label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant