Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Add ability to inject custom CAs - specifically for Thanos Sidecar #2185

Closed
MarkusBauerBE opened this issue Jun 23, 2022 · 5 comments
Labels
enhancement New feature or request lifecycle/stale

Comments

@MarkusBauerBE
Copy link

Is your feature request related to a problem ?

Right now self-hosted S3 services such as MinIO are not trusted by the Thanos sidecar when using a private CA. Injecting a custom CA certificate is not possible without touching or modifying the actual deployments. The helm chart doesn't currently allow for any injection of CA certs as far as I could tell - if so documentation for this is lacking.

This PR shows that this feature was implemented in Thanos itself and it theoretically should be as simple as adding a volume mount.

Describe the solution you'd like.

Ideally there'd be a way to either provide a secret or configmap to the prometheus or thanossidecar container that already mounts in the proper place.
If that is deemed to unflexible, then at least a way to mount secrets or configmaps with custom paths should be parsed through.

Describe alternatives you've considered.

From what I was able to gather an alternative is to set an environment variable that contains a path to the ca-bundle file. Setting env variables is however also not possible via the helm chart.

Additional context.

No response

@MarkusBauerBE MarkusBauerBE added the enhancement New feature or request label Jun 23, 2022
@MarkusBauerBE
Copy link
Author

Ping

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@cowjen01
Copy link
Contributor

The same issue here.

@stale stale bot removed the lifecycle/stale label Sep 16, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale
Copy link

stale bot commented Nov 9, 2022

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle/stale
Projects
None yet
Development

No branches or pull requests

2 participants