qt: decouple address type from combo index

Author: promag

src/qt/receivecoinsdialog.cpp

@@ -88,17 +88,18 @@ void ReceiveCoinsDialog::setModel(WalletModel *_model)
             &ReceiveCoinsDialog::recentRequestsView_selectionChanged);
 
         // Populate address type dropdown and select default
-        ui->addressType->insertItem((int)OutputType::LEGACY, "Base58 (Legacy)");
-        ui->addressType->setItemData((int)OutputType::LEGACY, "Not recommended due to higher fees and less protection against typos.", Qt::ToolTipRole);
-        ui->addressType->insertItem((int)OutputType::P2SH_SEGWIT, "Base58 (P2SH-SegWit)");
-        ui->addressType->setItemData((int)OutputType::P2SH_SEGWIT, "Generates an address compatible with older wallets.", Qt::ToolTipRole);
-        ui->addressType->insertItem((int)OutputType::BECH32, "Bech32 (SegWit)");
-        ui->addressType->setItemData((int)OutputType::BECH32, "Generates a native segwit addresses (BIP-173), which reduces your transaction fees later on and offers better protection against typos, but some old wallets don't support it.", Qt::ToolTipRole);
+        auto add_address_type = [&](OutputType type, const QString& text, const QString& tooltip) {
+            const auto index = ui->addressType->count();
+            ui->addressType->addItem(text, (int) type);
+            ui->addressType->setItemData(index, tooltip, Qt::ToolTipRole);
+            if (model->wallet().getDefaultAddressType() == type) ui->addressType->setCurrentIndex(index);
+        };
+        add_address_type(OutputType::LEGACY, "Base58 (Legacy)", "Not recommended due to higher fees and less protection against typos.");
+        add_address_type(OutputType::P2SH_SEGWIT, "Base58 (P2SH-SegWit)", "Generates an address compatible with older wallets.");
+        add_address_type(OutputType::BECH32, "Bech32 (SegWit)", "Generates a native segwit addresses (BIP-173), which reduces your transaction fees later on and offers better protection against typos, but some old wallets don't support it.");
         if (model->wallet().taprootEnabled()) {
-            ui->addressType->insertItem((int)OutputType::BECH32M, "Bech32m (Taproot)");
-            ui->addressType->setItemData((int)OutputType::BECH32M, "Although Bech32m (BIP-350) looks similar to Bech32, there is a slight difference and only some newer wallets support it.", Qt::ToolTipRole);
+            add_address_type(OutputType::BECH32M, "Bech32m (Taproot)", "Although Bech32m (BIP-350) looks similar to Bech32, there is a slight difference and only some newer wallets support it.");
         }
-        ui->addressType->setCurrentIndex((int)model->wallet().getDefaultAddressType());
 
         // Set the button to be enabled or disabled based on whether the wallet can give out new addresses.
         ui->receiveButton->setEnabled(model->wallet().canGetAddresses());
@@ -151,7 +152,7 @@ void ReceiveCoinsDialog::on_receiveButton_clicked()
     QString address;
     QString label = ui->reqLabel->text();
     /* Generate new receiving address */
-    const OutputType address_type = (OutputType)ui->addressType->currentIndex();
+    const OutputType address_type = (OutputType)ui->addressType->currentData().toInt();
     address = model->getAddressTableModel()->addRow(AddressTableModel::Receive, label, "", address_type);
 
     switch(model->getAddressTableModel()->getEditStatus())