Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1435183 - Fix how files are passed to hg annotate #39

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Feb 2, 2018

@stasm stasm requested review from Pike and removed request for Pike February 2, 2018 10:25
@stasm stasm requested a review from Pike February 2, 2018 12:34
@stasm
Copy link
Contributor Author

stasm commented Feb 2, 2018

@Pike The first commit here address the bug in question. add_transforms got pretty long so I decided to refactor it a bit in the second commit. It's mostly cosmetic if you don't feel like reviewing it.

Mercurial expects the file paths to be passed as variable positional arguments
to `hg annotate`. Remove the `--file` switch from the command builder.

It also expects at least one file path, so bail out from the migration early if
no legacy localization files were found.
@stasm stasm merged commit 175f358 into projectfluent:master Feb 2, 2018
@stasm stasm deleted the 1435183-file branch February 2, 2018 12:51
@stasm stasm added this to the python-fluent 0.6.1 milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants