Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent.syntax.ast.Visitor could use ignore_fields option #103

Open
Pike opened this issue Feb 25, 2019 · 0 comments
Open

fluent.syntax.ast.Visitor could use ignore_fields option #103

Pike opened this issue Feb 25, 2019 · 0 comments
Labels
fluent.syntax Issues related to the fluent.syntax module.

Comments

@Pike
Copy link
Contributor

Pike commented Feb 25, 2019

In BaseNode.equals, we have an ignore_fields option. That'd also be nice for Visitor, as it would allow a visitor to skip annotations and spans at the point of enumerating the properties, which is one or two cycles before actually going in to the Span or Annotation nodes, where we can handle them right now.

@Pike Pike added the fluent.syntax Issues related to the fluent.syntax module. label Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent.syntax Issues related to the fluent.syntax module.
Projects
None yet
Development

No branches or pull requests

1 participant