Remove deprecated BaseNode.traverse

In #97, we deprecated `BaseNode.traverse`. It's now time to remove it.
The reason it was still around is mostly for a niche in performance,
but dedicated iterators are probably the way to go for that niche.
That's what fluent.runtime does, for example.

Author: Pike

fluent.syntax/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## fluent.syntax 0.18 (not released)
+
+  - Documentation is now on https://projectfluent.org/python-fluent/fluent.syntax/.
+  - Removal of deprecated `BaseNode.traverse` method.
+
 ## fluent.syntax 0.17 (September 10, 2019)
 
   - Parser fix for whitespace before call arguments.

fluent.syntax/fluent/syntax/ast.py

@@ -112,33 +112,6 @@ class BaseNode(object):
     Annotation.  Implements __str__, to_json and traverse.
     """
 
-    def traverse(self, fun):
-        """DEPRECATED. Please use Visitor or Transformer.
-
-        Postorder-traverse this node and apply `fun` to all child nodes.
-
-        Traverse this node depth-first applying `fun` to subnodes and leaves.
-        Children are processed before parents (postorder traversal).
-
-        Return a new instance of the node.
-        """
-
-        def visit(value):
-            """Call `fun` on `value` and its descendants."""
-            if isinstance(value, BaseNode):
-                return value.traverse(fun)
-            if isinstance(value, list):
-                return fun(list(map(visit, value)))
-            else:
-                return fun(value)
-
-        # Use all attributes found on the node as kwargs to the constructor.
-        kwargs = vars(self).items()
-        node = self.__class__(
-            **{name: visit(value) for name, value in kwargs})
-
-        return fun(node)
-
     def clone(self):
         """Create a deep clone of the current node."""
         def visit(value):

fluent.syntax/tests/syntax/test_equals.py

@@ -5,10 +5,6 @@
 from fluent.syntax.parser import FluentParser
 
 
-def identity(node):
-    return node
-
-
 class TestEntryEqualToSelf(unittest.TestCase):
     def setUp(self):
         self.parser = FluentParser()
@@ -22,7 +18,6 @@ def test_same_simple_message(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
     def test_same_selector_message(self):
@@ -38,7 +33,6 @@ def test_same_selector_message(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
     def test_same_complex_placeable_message(self):
@@ -47,7 +41,6 @@ def test_same_complex_placeable_message(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
     def test_same_message_with_attribute(self):
@@ -57,7 +50,6 @@ def test_same_message_with_attribute(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
     def test_same_message_with_attributes(self):
@@ -68,7 +60,6 @@ def test_same_message_with_attributes(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
     def test_same_junk(self):
@@ -77,7 +68,6 @@ def test_same_junk(self):
         """)
 
         self.assertTrue(message1.equals(message1))
-        self.assertTrue(message1.equals(message1.traverse(identity)))
         self.assertTrue(message1.equals(message1.clone()))
 
 

fluent.syntax/tests/syntax/test_visitor.py

@@ -1,10 +1,7 @@
 from __future__ import unicode_literals
 
-import codecs
 from collections import defaultdict
-import os
 import unittest
-import timeit
 
 from fluent.syntax.parser import FluentParser
 from fluent.syntax import ast
@@ -121,75 +118,3 @@ def visit_TextElement(self, node):
         """Perform find and replace on text values only"""
         node.value = node.value.replace(self.before, self.after)
         return node
-
-
-class TestPerf(unittest.TestCase):
-    def setUp(self):
-        parser = FluentParser()
-        workload = os.path.join(
-            os.path.dirname(__file__), 'fixtures_perf', 'workload-low.ftl'
-        )
-        with codecs.open(workload, encoding='utf-8') as f:
-            self.resource = parser.parse(f.read())
-
-    def test_traverse(self):
-        counter = WordCounter()
-        self.resource.traverse(counter)
-        self.assertEqual(counter.word_count, 277)
-
-    def test_visitor(self):
-        counter = VisitorCounter()
-        counter.visit(self.resource)
-        self.assertEqual(counter.word_count, 277)
-
-    def test_edit_traverse(self):
-        edited = self.resource.traverse(ReplaceText('Tab', 'Reiter'))
-        self.assertEqual(
-            edited.body[4].attributes[0].value.elements[0].value,
-            'New Reiter'
-        )
-
-    def test_edit_transform(self):
-        edited = ReplaceTransformer('Tab', 'Reiter').visit(self.resource)
-        self.assertEqual(
-            edited.body[4].attributes[0].value.elements[0].value,
-            'New Reiter'
-        )
-
-    def test_edit_cloned(self):
-        edited = ReplaceTransformer('Tab', 'Reiter').visit(self.resource.clone())
-        self.assertEqual(
-            edited.body[4].attributes[0].value.elements[0].value,
-            'New Reiter'
-        )
-
-
-def gather_stats(method, repeat=10, number=50):
-    t = timeit.Timer(
-        setup='''
-from tests.syntax import test_visitor
-test = test_visitor.TestPerf('test_{}')
-test.setUp()
-'''.format(method),
-        stmt='test.test_{}()'.format(method)
-    )
-    return [
-        result/number for result in
-        t.repeat(repeat=repeat, number=number)
-    ]
-
-
-if __name__ == '__main__':
-    for m in (
-        'traverse',
-        'visitor',
-        'edit_traverse',
-        'edit_transform',
-        'edit_cloned',
-    ):
-        results = gather_stats(m)
-        try:
-            import statistics
-            print("{}:\t{}".format(m, statistics.mean(results)))
-        except ImportError:
-            print("{}:\t{}".format(m, sum(results)/len(results)))