Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults for guidelines on Configuring Envoy as an Edge Proxy #4717

Open
1 task
sunjayBhatia opened this issue Sep 12, 2022 · 7 comments
Open
1 task
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Sep 12, 2022

Envoy provides documentation guidelines on Configuring Envoy as an edge proxy

Contour has implemented some of these guidelines, but we should do another pass to make sure we have covered it all, for proxying TLS/TCP, HTTP/1.1, HTTP/2, etc.

There may be duplicates of this issue that can be linked, closed, etc. as needed

Tasks:

@sunjayBhatia sunjayBhatia added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Sep 12, 2022
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2022
@sunjayBhatia
Copy link
Member Author

Seems still valuable to do, unstaling

@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2023
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@Daxcor69
Copy link

Daxcor69 commented Feb 3, 2023

Can you provide a way to make these changes? I am trying to find out where to make these changes..

@sunjayBhatia
Copy link
Member Author

Can you provide a way to make these changes? I am trying to find out where to make these changes..

This will require code changes to Contour to configure Envoy with some of these values

@Daxcor69
Copy link

Daxcor69 commented Feb 3, 2023

Is this not what contour is, making envoy an edge proxy not a service mesh? Why would these values not be exposed by default?

@sunjayBhatia
Copy link
Member Author

Contour does not aim to make every envoy configuration knob available to users to configure, this issue and the linked Envoy guidelines are for sensible defaults that we should apply, which involve code changes to Contour so the xDS server can send them to Envoy. Some values may additionally be exposed as user configurable, but that again involves code changes to Contour to expose those in an API and to send that configuration to Envoy.

@sunjayBhatia sunjayBhatia added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: No status
Development

No branches or pull requests

2 participants