Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit decision to make open listeners optional #389

Closed
davecheney opened this issue May 15, 2018 · 3 comments
Closed

Revisit decision to make open listeners optional #389

davecheney opened this issue May 15, 2018 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@davecheney
Copy link
Contributor

#385 raised the question that the current behaviour of not opening a listener until there is a valid ingress, while justified, is non obvious for newcomers, especially in the case where the AWS elb won’t go green until an ingress is deployed.

This issue tracks the decision to revert this and potentially always open listeners on 80 and 443. This has implications for security (opening ports we don’t necessarily need which might leak routes unintentionally — defence in depth) and for health checks for contour.

@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. documentation labels May 15, 2018
@davecheney davecheney added this to the 0.7.0 milestone May 15, 2018
@davecheney davecheney modified the milestones: 0.7.0, 0.8.0 Oct 8, 2018
@davecheney
Copy link
Contributor Author

This is not going to be addressed in the 0.7 timeframe.

@stevesloka
Copy link
Member

The use-case of not having a health check endpoint is now resolved as that exists on a different listener. I think at this point, not creating a listener or returning a 404 since no paths are defined are almost the same UX.

@davecheney
Copy link
Contributor Author

The current behaviour -- contour does not open an accepting socket until there is traffic to serve on that socket will remain the behaviour for contour 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

2 participants