Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt HTTP ConnectionManager strip_matching_host_port #2752

Closed
jpeach opened this issue Jul 31, 2020 · 2 comments
Closed

Adopt HTTP ConnectionManager strip_matching_host_port #2752

jpeach opened this issue Jul 31, 2020 · 2 comments
Labels
blocked Blocked waiting on a dependency

Comments

@jpeach
Copy link
Contributor

jpeach commented Jul 31, 2020

Please describe the problem you have

Currently, we duplicate virtual host entries to allow them to match when a port is specified in the Host header. We can drop this and use strip_matching_host_port instead.

https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto
@jpeach jpeach added the blocked Blocked waiting on a dependency label Jul 31, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Jul 31, 2020

Blocked on #1898

@sunjayBhatia
Copy link
Member

closing, we're already using the strip_any_host_port option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked waiting on a dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpeach @sunjayBhatia