Skip to content

Commit e49a07f

Browse files
committed
added to OnChange() for getting loaded during DAG build
1 parent c2c5e56 commit e49a07f

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

apis/projectcontour/v1alpha1/contourconfig.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ type EnvoyListenerConfig struct {
438438
// connection open where possible (if the entire request is read for HTTP/1.1)
439439
//
440440
// +optional
441-
StreamErrorOnInvalidHTTP bool `json:"streamErrorOnInvalidHTTP,omitempty"`
441+
StreamErrorOnInvalidHTTP *bool `json:"streamErrorOnInvalidHTTP,omitempty"`
442442
}
443443

444444
// SocketOptions defines configurable socket options for Envoy listeners.

internal/xdscache/v3/listener.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,7 @@ func (c *ListenerCache) OnChange(root *dag.DAG) {
402402
StripTrailingHostDot(cfg.StripTrailingHostDot).
403403
MaxRequestsPerConnection(cfg.MaxRequestsPerConnection).
404404
HTTP2MaxConcurrentStreams(cfg.HTTP2MaxConcurrentStreams).
405+
StreamErrorOnInvalidHTTP(cfg.StreamErrorOnInvalidHTTP).
405406
AddFilter(httpGlobalExternalAuthConfig(cfg.GlobalExternalAuthConfig)).
406407
Tracing(envoy_v3.TracingConfig(envoyTracingConfig(cfg.TracingConfig))).
407408
AddFilter(envoy_v3.GlobalRateLimitFilter(envoyGlobalRateLimitConfig(cfg.RateLimitConfig))).
@@ -482,6 +483,7 @@ func (c *ListenerCache) OnChange(root *dag.DAG) {
482483
ForwardClientCertificate(forwardClientCertificate).
483484
MaxRequestsPerConnection(cfg.MaxRequestsPerConnection).
484485
HTTP2MaxConcurrentStreams(cfg.HTTP2MaxConcurrentStreams).
486+
StreamErrorOnInvalidHTTP(cfg.StreamErrorOnInvalidHTTP).
485487
EnableWebsockets(listener.EnableWebsockets).
486488
Get()
487489

@@ -565,6 +567,7 @@ func (c *ListenerCache) OnChange(root *dag.DAG) {
565567
ForwardClientCertificate(forwardClientCertificate).
566568
MaxRequestsPerConnection(cfg.MaxRequestsPerConnection).
567569
HTTP2MaxConcurrentStreams(cfg.HTTP2MaxConcurrentStreams).
570+
StreamErrorOnInvalidHTTP(cfg.StreamErrorOnInvalidHTTP).
568571
EnableWebsockets(listener.EnableWebsockets).
569572
Get()
570573

pkg/config/parameters.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,8 @@ func Defaults() Parameters {
11121112
EnvoyAdminPort: 9001,
11131113
},
11141114
Listener: ListenerParameters{
1115-
ConnectionBalancer: "",
1115+
ConnectionBalancer: "",
1116+
StreamErrorOnInvalidHTTP: false,
11161117
},
11171118
}
11181119
}

0 commit comments

Comments
 (0)