Skip to content

Beat detection values (bass, mid, treb + _att variants) are too high. #708

@kblaschke

Description

@kblaschke

While working on integrating the new preset parser and rewriting the preset rendering process, I noticed some presets were behaving highly erratic or were completely broken (e.g. "shifter - robotopia"). I've tracked down these issues to the beat values being way too high.

The Milkdrop preset authoring guide isn't very specific about the actual value range (>0), but says that the values are expected to be in the range from 0.7 to 1.3 in general and around 1.0 if the levels don't change much.

Looking at Milkdrop's audio analyzing code, these values aren't absolute sums/averages of the current frequency spectrum intensity, but rather slighly or more smoothed relative values to the intensities of previous frames.

@ErikPrantare - you've refactored the beat detection code a while ago. Would you mind looking into this again and implement it in a more Milkdrop'esque way to keep the value ranges in the expected range?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThe issue is (potentially) a bug.optimizationA general optimization to performance, RAM usage or UX.

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions