Free/Alloc scene buffer to correct heap #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After discussing with Fizzi, it was deemed this original PR would have broke console. So the code has been switched back to a version of the one shot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSD_FreeandHSD_MemAllocboth do their operations on the "HSD" heap, which means in the previous iterations of this code, the buffer was getting created on the wrong heap.The heap created in the bootloader is the first one that gets created, and isn't destroyed by the game. So instead of using the HSD specific functions, this code uses OS calls to free/alloc the buffer to the correct heap.