Populate the dedicated view of direct messages ("People") in the rooms list

[kevinaboos]

Now that we have a new UI, this should be relatively straightforward. All we need to do is determine whether a room is a direct message, which can be done via multiple different SDK APIs:

• https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk/ruma/api/client/sync/sync_events/v4/struct.SlidingSyncRoom.html#structfield.is_dm
• https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk/room/struct.Room.html#method.is_direct

Then, those "direct" rooms should be placed under the People heading of the rooms list, and thus they should not appear under the Rooms heading any more.

Note that the collapsible section headers don't actually collapse/expand yet -- that is a known missing feature. Added by #470, so this is ready to be implemented!

[aaravlu]

I'm confused about a few things.

1. What is the difference between the is_dm field and the is_direct method?
2. And it seems that the is_dm field is missing from the latest git repository? Maybe I should try the is_dm filed under ssroom ?
3. I made a copy of rooms_list.rs under home dir as "people_list.rs", then changed all the names related to Rooms to People, and then in sliding_sync.rs I stripped out the dm rooms, to match what's in people_list.rs, and then in rooms_sidebar.rs, I added the PeopleList (like RoomsList ), which shhould have contained the peeled dm rooms in people_list.rs. But why does it still not work?

https://github.com/Demolemon11/robrix/blob/main/src/sliding_sync.rs
The line numbers of the code related to dm rooms stripping in "sliding_sync.rs" are 996, 1016, 1047 and1120

[kevinaboos]

I'm confused about a few things.

1. What is the difference between the is_dm field and the is_direct method?

I think they're the same, but I'm not sure since I haven't tried it myself.

2. And it seems that the is_dm field is missing from the latest git repository? Maybe I should try the is_dm filed under ssroom ?

Also not sure. I know the sdk is in the middle of major changes, specifically that the old sliding sync is being removed in favor of the new "simplified" sliding sync.

3. I made a copy of rooms_list.rs under home dir as "people_list.rs", then changed all the names related to Rooms to People, and then in sliding_sync.rs I stripped out the dm rooms, to match what's in people_list.rs, and then in rooms_sidebar.rs, I added the PeopleList (like RoomsList ), which shhould have contained the peeled dm rooms in people_list.rs. But why does it still not work?

Hard to know for sure without seeing your code; if you have some code, feel free to submit a PR. But in general, we don't want to duplicate the views because we want DMs to be shown in the same Rooms List view, so I don't think that's the best way forward.

I think all you'd need to do is when drawing the rooms list, sort each room under the proper Rooms or People heading based on whether it's a DM room.

[aaravlu]

Are you saying that my changing sliding_sync.rs is wrong, and I shouldn't have to determine if it's a DM or not in such a low-level module?

[aaravlu]

At the begining, I just didnot want to modify sliding_sync.rs, I know the whole structure of the project would be chaos if I peel DM room in sliding_sync.rs
I am a green hand to Rust, Matrix, and makepad, So I hope you understand me : )

[kevinaboos]

Are you saying that my changing sliding_sync.rs is wrong, and I shouldn't have to determine if it's a DM or not in such a low-level module?

ah, no, I wasn't saying that, sorry. You may need to check whether a room is a DM/direct room within the "backend" (the sliding_sync module) and then include that information in the RoomPreviewInfo that gets sent to the UI main thread.

https://github.com/Demolemon11/robrix/blob/main/src/sliding_sync.rs
The line numbers of the code related to dm rooms stripping in "sliding_sync.rs" are 996, 1016, 1047 and1120

Those don't seem to be the correct line numbers, as they're completely irrelevant to DM stuff. If you want a proper code review, please submit a PR -- git has tools for this purpose. Links to separate code files are not reviewable.

At the begining, I just didnot want to modify sliding_sync.rs, I know the whole structure of the project would be chaos if I peel DM room in sliding_sync.rs
I am a green hand to Rust, Matrix, and makepad, So I hope you understand me : )

yea no problem! don't worry, we're here to help as much as possible.

[kevinaboos]

Also, I'm literally attending the Matrix Conference in Berlin today, and this slide came up in a talk about the future of sliding sync (which involves moving from the sliding sync proxy to the sliding sync native version).

It seems to indicate that is_dm() is being removed, so I'd recommend that we don't use that function.

[alanpoon]

I am looking at this issue.

[alanpoon]

It seems like room_list is inside cached_widget.

robrix/src/home/rooms_sidebar.rs

Line 152 in df4f372

rooms_list = <RoomsList> {}

It is not possible to differentiate room_type as property in the roomlist's draw_walk function as there can only be 1 instance: e.g

<CachedWidget>{ room_list = <RoomList>{ room_type: "people" } } <CachedWidget>{ room_list = <RoomList>{ room_type: "room" } } fn draw_walk(&mut self, cx: &mut Cx2d, scope: &mut Scope, walk: Walk) -> DrawStep { self.room_type --> will always be "people". }
@kevinaboos Is there a way to pass "room_type" property into CachedWidget?

[alanpoon]

It seems like room_list is inside cached_widget.

robrix/src/home/rooms_sidebar.rs

Line 152 in df4f372

rooms_list = <RoomsList> {}

It is not possible to differentiate room_type as property in the roomlist's draw_walk function as there can only be 1 instance: e.g

<CachedWidget>{ room_list = <RoomList>{ room_type: "people" } } <CachedWidget>{ room_list = <RoomList>{ room_type: "room" } } fn draw_walk(&mut self, cx: &mut Cx2d, scope: &mut Scope, walk: Walk) -> DrawStep { self.room_type --> will always be "people". } @kevinaboos Is there a way to pass "room_type" property into CachedWidget?

I will try passing the property through context.