This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Open
Conversation
57503bd to
832ed69
Compare
Codecov Report
@@ Coverage Diff @@
## develop #71 +/- ##
========================================
Coverage 68.36% 68.36%
========================================
Files 9 9
Lines 411 411
Branches 50 50
========================================
Hits 281 281
Misses 123 123
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PM-557
Description
Whenever you would start the simulation, the input device would not accurately display the available gaits. This could be fixed by pressing the "Refresh" button. This behaviour can be changed in multiple ways, such as:
I have chosen the second option, since it ensures that the input device will always reflect the current state of the state machine. Besides that, the gait state machine is being refactored right now in project-march/march#583 and changing behaviour in the state machine would probably result in unnecessary merge conflicts.
Changes
This pull request replaces the manual "Refresh" button with an automatic timer, so you don't have to press the "Refresh" button on startup or when an incorrect state is displayed on the input device.
Testing