Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

enable the registry #28

Closed
rmkraus opened this issue Jun 13, 2020 · 5 comments · Fixed by #173
Closed

enable the registry #28

rmkraus opened this issue Jun 13, 2020 · 5 comments · Fixed by #173
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rmkraus
Copy link
Member

rmkraus commented Jun 13, 2020

farosctl oc patch configs.imageregistry.operator.openshift.io cluster --type merge --patch '{"spec":{"storage":{"pvc":{"claim":""}}}}'
farosctl oc patch configs.imageregistry.operator.openshift.io/cluster --type merge -p '{"spec":{"managementState":"Managed"}}'
@rmkraus
Copy link
Member Author

rmkraus commented Jul 17, 2020

a default storage class must be set first.

@rmkraus rmkraus added the enhancement New feature or request label Aug 4, 2020
@rmkraus rmkraus closed this as completed Jul 1, 2021
@mulbc
Copy link
Member

mulbc commented Aug 9, 2021

@rmkraus has this ever been solved? I can't find any code for imageregistry and there are no commits associated with this issue

@mulbc mulbc reopened this Aug 9, 2021
@rmkraus
Copy link
Member Author

rmkraus commented Aug 9, 2021

Yes, this was resolved in the docs: https://faros.dev/storage.html#enable-cluster-registry

Do you think this should be somewhere else? The main reason I hadn't put this in the storage install script is because I don't want to programatically wait for storage to be available. Then again, there really isn't a need to wait as k8s will simply create the pv when the storageclass becomes available.

What do you think?

@mulbc
Copy link
Member

mulbc commented Aug 16, 2021

As a customer I would expect my OpenShift cluster to come with a working Registry. By default we cannot offer this on Bare Metal, since we don't know if a suitable storage is available.
For Faros, we do know that a suitable Storage is available, since we make sure to install it - so IMO we should enable the registry after the storage is installed.
We unfortuantely cannot just configure the registry and let it retry once storage is installed, since the PVCs would be stuck (if created before the provisioner / storage class is there). So we will have to first install ODF, then configure the Registry

@mulbc mulbc self-assigned this Aug 16, 2021
@rmkraus rmkraus added this to the 4.8.0 milestone Aug 17, 2021
@rmkraus
Copy link
Member Author

rmkraus commented Aug 18, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants