Updating attribute and command queries to use packageIds such that custom extensions for standard clusters are handled appropriately #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Sep 9, 2022
brdandu
commented
- When a cluster extension is added to standard clusters in the form of attributes or commands through custom xml then there is a need to account for packageIds
- For eg if a user adds a custom xml for the above use case and removes it the generation continues to generate for the added custom xml since it is not checking for removed packages.
- Github: ZAP#698
tecimovic
approved these changes
Sep 13, 2022
…stom extensions for standard clusters are handled appropriately - When a cluster extension is added to standard clusters in the form of attributes or commands through custom xml then there is a need to account for packageIds - For eg if a user adds a custom xml for the above use case and removes it the generation continues to generate for the added custom xml since it is not checking for removed packages. - Github: ZAP#698
… for standard clusters Github: ZAP#698
brdandu
force-pushed
the
bug/packageIdsForCustomXml/ZAP#698
branch
from
3a5fc3d
to
61aff8a
Compare
Yeah I created a chip repo branch and tested it with these changes. It passed the CI process in the following draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.