Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K32W] Sync button push with cluster state #8761

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Aug 3, 2021

Problem

If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.

Change overview

Sync the cluster state:

  • for the elock: each time the lock/unlock button is pushed;
  • for the lighting app: each time the turn on/turn off button is pushed.

Testing

Manually tested.

@doru91
Copy link
Contributor Author

doru91 commented Aug 10, 2021

Why is the "CHIP-PR-upload (matter-build-automation)" failing? I see a message "Needs /gcbrun from a collaborator" but I don't know how to solve it.

@bzbarsky-apple
Copy link
Contributor

/gcbrun

@bzbarsky-apple
Copy link
Contributor

/rebase

doru91 and others added 3 commits August 10, 2021 23:21
If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
@github-actions
Copy link

Size increase report for "esp32-example-build" from b3f7d9f

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-lock-app.elf .flash.text -68 -68
chip-shell.elf .flash.text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,68
.flash.text,-68,-68

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,12
.flash.text,-12,-12

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit 2ee1e70 into project-chip:master Aug 11, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* [K32W] Sync button push with cluster state

If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* [K32W] Sync button push with cluster state

If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants