Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin] Fix incorrect Thread panID generation #8562

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

sagar-apple
Copy link
Contributor

Problem

The underlying cpp implementation assumes(with no documentation) that the input panID is meant to be in Big-Endian.

Change overview

Explicitly convert from Host order to BE when constructing the underlying cpp structure. And make sure to convert back into Host order when pulling information out of a buffer again.

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
    Added a unit test to convert individual fields to a data buffer and then reconstruct the individual fields from that data buffer

@github-actions
Copy link

Size increase report for "esp32-example-build" from c4fe313

File Section File VM
chip-lock-app.elf .flash.text -64 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize


@yufengwangca yufengwangca merged commit 5d3695b into project-chip:master Jul 22, 2021
@sagar-apple sagar-apple deleted the panID_endianness branch July 22, 2021 21:50
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* [Darwin] Fix incorrect Thread panID generation

* Fix restyled issue

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants