-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Fix incorrect Thread panID generation #8562
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
sagar-apple:panID_endianness
Jul 22, 2021
Merged
[Darwin] Fix incorrect Thread panID generation #8562
yufengwangca
merged 2 commits into
project-chip:master
from
sagar-apple:panID_endianness
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-apple
force-pushed
the
panID_endianness
branch
from
July 22, 2021 02:56
6bd11ba
to
6585096
Compare
woody-apple
approved these changes
Jul 22, 2021
pullapprove
bot
requested review from
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt,
vivien-apple and
yufengwangca
July 22, 2021 04:28
sagar-apple
force-pushed
the
panID_endianness
branch
from
July 22, 2021 14:59
9277d20
to
790d7b7
Compare
Damian-Nordic
approved these changes
Jul 22, 2021
LuDuda
approved these changes
Jul 22, 2021
Size increase report for "esp32-example-build" from c4fe313
Full report output
|
bzbarsky-apple
approved these changes
Jul 22, 2021
yufengwangca
approved these changes
Jul 22, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [Darwin] Fix incorrect Thread panID generation * Fix restyled issue Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The underlying cpp implementation assumes(with no documentation) that the input panID is meant to be in Big-Endian.
Change overview
Explicitly convert from Host order to BE when constructing the underlying cpp structure. And make sure to convert back into Host order when pulling information out of a buffer again.
Testing
How was this tested? (at least one bullet point required)
Added a unit test to convert individual fields to a data buffer and then reconstruct the individual fields from that data buffer