-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic cluster tests for attributes constraints #7792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but @tcarmelveilleux's comment about the max length there should be addressed, either here or in a followup.
cae20a8
to
c664ccf
Compare
@vivien-apple conflicts :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs conflict resolution.
Cannot easily review this due to large amoung of generated code.
…le and reformat it to make it easier to read when comparing to the spec
…nd src/controller/data_model
…the basic clusters startups
c664ccf
to
493e82d
Compare
Size increase report for "esp32-example-build" from 42c2ccd
Full report output
|
Size increase report for "gn_qpg6100-example-build" from 42c2ccd
Full report output
|
Size increase report for "nrfconnect-example-build" from 42c2ccd
Full report output
|
@andy31415 fwiw, reviewing the individual changesets worked pretty well for me for this one.... |
* Extract Basic Information from general.xml to have it into its own file and reformat it to make it easier to read when comparing to the spec * Use the updated Basic Information Cluster into the all-clusters-app and src/controller/data_model * Do not overwrite the interaction model version defined from zap when the basic clusters startups * Update templates to support _optional_ property on test as well as _constraints_ * Update the all-clusters-app.zap file with a fake manufacturing date for the basic cluster * Add Test_10_1_1.yaml file * Use optional for TestCluster unsupported attribute * Update gen/ folders
Problem
There is no specific tests for the
Basic
cluster.Change overview
Basic
cluster definition out of the Silabs's definition and update it a littleTest_10_1_1
for theBasic cluster
optional
keyword, such that an attribute is tested only if it is supported on the accessory sideconstraints
keywordminLength
/maxLength
constraints support (format
andtype
still needs to be done)Testing
Darwin CI
and the test suites usingchip-tool