Try to support MacOS with CHIP.xcodeproj #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
woody-apple
approved these changes
May 19, 2020
gerickson
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 58.39% 57.92% -0.48%
==========================================
Files 130 130
Lines 12646 12646
==========================================
- Hits 7385 7325 -60
- Misses 5261 5321 +60
Continue to review full report at Codecov.
|
saurabhst
approved these changes
May 19, 2020
|
Holding to confirm one thing about this is building right... |
| @@ -20,6 +18,8 @@ | |||
| B2E0D7B8245B0B5C003C5B48 /* CHIPSetupPayload.h in Headers */ = {isa = PBXBuildFile; fileRef = B2E0D7AF245B0B5C003C5B48 /* CHIPSetupPayload.h */; settings = {ATTRIBUTES = (Public, ); }; }; | |||
There was a problem hiding this comment.
As discussed offline, we need a Build Target that will be a macOS framework. That target will essentially be a duplicate of the iOS except it builds against macOS SDK and for macOS platform.
You can right click the current iOS target and hit "Duplicate" and update the SDK it builds against. And then the build script can do its thing as it is now.
There was a problem hiding this comment.
not necessary, yay!
rwalker-apple
changed the title
rwalker-apple
force-pushed
the
Support-MacOS-with-CHIP.xcodeproj
branch
from
3cd8d6e
to
d2ea49a
Compare
fixups restyle
rwalker-apple
force-pushed
the
Support-MacOS-with-CHIP.xcodeproj
branch
from
d2ea49a
to
0cd09d5
Compare
jmartinez-silabs
added a commit
to SiliconLabs/matter
that referenced
this pull request
May 18, 2023
… is defined. make sure that it is (project-chip#26460) Merge in WMN_TOOLS/matter from cherry-pick/Fix_multicast_addr_endianness to RC_2.0.0-1.1 Squashed commit of the following: commit 50f8a0590cfbfb2c0d69798efb641c4d4de1a7c2 Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Date: Wed May 10 09:24:21 2023 -0400 Inet implementations assume BYTE_ORDER is defined. make sure that it is (project-chip#26460) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Summary of Changes