-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to support MacOS with CHIP.xcodeproj #765
Try to support MacOS with CHIP.xcodeproj #765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 58.39% 57.92% -0.48%
==========================================
Files 130 130
Lines 12646 12646
==========================================
- Hits 7385 7325 -60
- Misses 5261 5321 +60
Continue to review full report at Codecov.
|
Holding to confirm one thing about this is building right... |
@@ -20,6 +18,8 @@ | |||
B2E0D7B8245B0B5C003C5B48 /* CHIPSetupPayload.h in Headers */ = {isa = PBXBuildFile; fileRef = B2E0D7AF245B0B5C003C5B48 /* CHIPSetupPayload.h */; settings = {ATTRIBUTES = (Public, ); }; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we need a Build Target that will be a macOS framework. That target will essentially be a duplicate of the iOS except it builds against macOS SDK and for macOS platform.
You can right click the current iOS target and hit "Duplicate" and update the SDK it builds against. And then the build script can do its thing as it is now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessary, yay!
3cd8d6e
to
d2ea49a
Compare
fixups restyle
d2ea49a
to
0cd09d5
Compare
… is defined. make sure that it is (project-chip#26460) Merge in WMN_TOOLS/matter from cherry-pick/Fix_multicast_addr_endianness to RC_2.0.0-1.1 Squashed commit of the following: commit 50f8a0590cfbfb2c0d69798efb641c4d4de1a7c2 Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Date: Wed May 10 09:24:21 2023 -0400 Inet implementations assume BYTE_ORDER is defined. make sure that it is (project-chip#26460) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Problems
Summary of Changes