-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll up third_party/pigweed/repo to ToT #4044
Conversation
@@ -39,6 +39,9 @@ _bootstrap_or_activate() { | |||
EOF | |||
)" | |||
|
|||
PW_PROJECT_ROOT="$_CHIP_ROOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pigweed's virtualenv setup requires this be correctly set, for e.g. python modules outside of Pigweed repo be possible to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the environment creep problematic, but it's not your fault so I'll take it up elsewhere.
Can you delete the old .environment in bootstrap? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should delete the old .environment to save all developers 4G+ of space
- Lint fails. Please disable lint or fix the errors:
yuif:30320:~/connectedhomeip2% gn gen out/host
nDone. Made 267 targets from 104 files in 192ms
yuif:30321:~/connectedhomeip2% ninja -C out/host all
ninja: Entering directory `out/host'
[27/584] ACTION //integrations/mobly/py:py.wheel(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/py.wheel.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/py.wheel.pw_pystamp --capture-output -- /home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py --out_dir /home/spang/connectedhomeip2/out/host/obj/integrations/mobly/py /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/__init__.py /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py /home/spang/connectedhomeip2/integrations/mobly/py/setup.py
Traceback (most recent call last):
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 64, in <module>
main()
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 59, in main
build_wheels(**vars(_parse_args()))
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 43, in build_wheels
raise RuntimeError(f'Unable to find setup.py file at {filename}.')
RuntimeError: Unable to find setup.py file at /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/__init__.py.
[36/584] ACTION //integrations/mobly/py:py.lint.pylint(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/setup.py.pylint.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --directory /home/spang/connectedhomeip2/ --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/setup.py.pylint.pw_pystamp --capture-output --module pylint -- integrations/mobly/py/setup.py --jobs=1 --output-format=colorized
************* Module setup
integrations/mobly/py/setup.py:26:1: W0511: TODO - uncomment this once native python building is solved for (fixme)
integrations/mobly/py/setup.py:23:0: C0330: Wrong hanging indentation (add 4 spaces).
# author_email='?',
^ | (bad-continuation)
integrations/mobly/py/setup.py:26:0: C0330: Wrong hanging indentation (add 4 spaces).
#TODO - uncomment this once native python building is solved for
^ | (bad-continuation)
--------------------------------------------------------------------
Your code has been rated at -5.00/10 (previous run: -5.00/10, +0.00)
[39/584] ACTION //integrations/mobly/py:py.lint.mypy(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/py.lint.mypy.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --env=MYPY_FORCE_COLOR=1 --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/py.lint.mypy.pw_pystamp --capture-output --module mypy -- --pretty --show-error-codes /home/spang/connectedhomeip2/integrations/mobly/py
/home/spang/connectedhomeip2/integrations/mobly/py/setup.py:17: error: Skipping
analyzing 'setuptools': found module but no type hints or library stubs
[import]
import setuptools
^
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:17: error:
Skipping analyzing 'serial': found module but no type hints or library stubs
[import]
import serial
^
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:17: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:20: error:
Skipping analyzing 'pw_hdlc_lite.rpc': found module but no type hints or library
stubs [import]
from pw_hdlc_lite.rpc import HdlcRpcClient
^
/home/spang/connectedhomeip2/integrations/mobly/py/hello_world_test.py:16: error:
Skipping analyzing 'mobly': found module but no type hints or library stubs
[import]
from mobly import asserts
^
Found 4 errors in 3 files (checked 4 source files)
[40/584] ACTION //integrations/mobly/py:py.lint.pylint(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/chip_mobly/pigweed_device.py.pylint.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --directory /home/spang/connectedhomeip2/ --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/chip_mobly/pigweed_device.py.pylint.pw_pystamp --capture-output --module pylint -- integrations/mobly/py/chip_mobly/pigweed_device.py --jobs=1 --output-format=colorized
************* Module chip_mobly.pigweed_device
integrations/mobly/py/chip_mobly/pigweed_device.py:1:0: C0114: Missing module docstring (missing-module-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:32:0: C0115: Missing class docstring (missing-class-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:39:12: C0103: Variable name "m" doesn't conform to snake_case naming style (invalid-name)
integrations/mobly/py/chip_mobly/pigweed_device.py:43:4: C0116: Missing function or method docstring (missing-function-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:47:4: C0116: Missing function or method docstring (missing-function-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:74:4: W0107: Unnecessary pass statement (unnecessary-pass)
integrations/mobly/py/chip_mobly/pigweed_device.py:18:0: C0411: standard import "import importlib" should be placed before "import serial" (wrong-import-order)
------------------------------------------------------------------
Your code has been rated at 8.06/10 (previous run: 8.06/10, +0.00)
ninja: build stopped: subcommand failed.
c87ab64
to
fac2999
Compare
@mspang please try now |
|
fac2999
to
6d5fb62
Compare
@mspang try again please |
Problem
Recent Pigweed RPC changes are needed to support host-driven on-device testing.
Related PR: #3930
Summary of Changes
Rolling up third_party/pigweed/repo to a recent commit.