Roll up third_party/pigweed/repo to ToT #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton and
saurabhst
mspang
reviewed
Dec 1, 2020
| @@ -39,6 +39,9 @@ _bootstrap_or_activate() { | |||
| EOF | |||
| )" | |||
|
|
|||
| PW_PROJECT_ROOT="$_CHIP_ROOT" | |||
There was a problem hiding this comment.
Pigweed's virtualenv setup requires this be correctly set, for e.g. python modules outside of Pigweed repo be possible to install.
There was a problem hiding this comment.
I find the environment creep problematic, but it's not your fault so I'll take it up elsewhere.
andy31415
approved these changes
Dec 1, 2020
rwalker-apple
approved these changes
Dec 1, 2020
mspang
approved these changes
Dec 1, 2020
|
Can you delete the old .environment in bootstrap? |
mspang
requested changes
Dec 1, 2020
There was a problem hiding this comment.
- We should delete the old .environment to save all developers 4G+ of space
- Lint fails. Please disable lint or fix the errors:
yuif:30320:~/connectedhomeip2% gn gen out/host
nDone. Made 267 targets from 104 files in 192ms
yuif:30321:~/connectedhomeip2% ninja -C out/host all
ninja: Entering directory `out/host'
[27/584] ACTION //integrations/mobly/py:py.wheel(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/py.wheel.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/py.wheel.pw_pystamp --capture-output -- /home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py --out_dir /home/spang/connectedhomeip2/out/host/obj/integrations/mobly/py /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/__init__.py /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py /home/spang/connectedhomeip2/integrations/mobly/py/setup.py
Traceback (most recent call last):
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 64, in <module>
main()
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 59, in main
build_wheels(**vars(_parse_args()))
File "/home/spang/connectedhomeip2/third_party/pigweed/repo/pw_build/py/pw_build/python_wheels.py", line 43, in build_wheels
raise RuntimeError(f'Unable to find setup.py file at {filename}.')
RuntimeError: Unable to find setup.py file at /home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/__init__.py.
[36/584] ACTION //integrations/mobly/py:py.lint.pylint(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/setup.py.pylint.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --directory /home/spang/connectedhomeip2/ --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/setup.py.pylint.pw_pystamp --capture-output --module pylint -- integrations/mobly/py/setup.py --jobs=1 --output-format=colorized
************* Module setup
integrations/mobly/py/setup.py:26:1: W0511: TODO - uncomment this once native python building is solved for (fixme)
integrations/mobly/py/setup.py:23:0: C0330: Wrong hanging indentation (add 4 spaces).
# author_email='?',
^ | (bad-continuation)
integrations/mobly/py/setup.py:26:0: C0330: Wrong hanging indentation (add 4 spaces).
#TODO - uncomment this once native python building is solved for
^ | (bad-continuation)
--------------------------------------------------------------------
Your code has been rated at -5.00/10 (previous run: -5.00/10, +0.00)
[39/584] ACTION //integrations/mobly/py:py.lint.mypy(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/py.lint.mypy.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --env=MYPY_FORCE_COLOR=1 --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/py.lint.mypy.pw_pystamp --capture-output --module mypy -- --pretty --show-error-codes /home/spang/connectedhomeip2/integrations/mobly/py
/home/spang/connectedhomeip2/integrations/mobly/py/setup.py:17: error: Skipping
analyzing 'setuptools': found module but no type hints or library stubs
[import]
import setuptools
^
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:17: error:
Skipping analyzing 'serial': found module but no type hints or library stubs
[import]
import serial
^
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:17: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
/home/spang/connectedhomeip2/integrations/mobly/py/chip_mobly/pigweed_device.py:20: error:
Skipping analyzing 'pw_hdlc_lite.rpc': found module but no type hints or library
stubs [import]
from pw_hdlc_lite.rpc import HdlcRpcClient
^
/home/spang/connectedhomeip2/integrations/mobly/py/hello_world_test.py:16: error:
Skipping analyzing 'mobly': found module but no type hints or library stubs
[import]
from mobly import asserts
^
Found 4 errors in 3 files (checked 4 source files)
[40/584] ACTION //integrations/mobly/py:py.lint.pylint(//build/toolchain/host:linux_x64_gcc)
FAILED: gen/integrations/mobly/py/chip_mobly/pigweed_device.py.pylint.pw_pystamp
python3 ../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root /home/spang/connectedhomeip2/ --current-path /home/spang/connectedhomeip2/integrations/mobly/py --default-toolchain=//build/toolchain/host:linux_x64_gcc --current-toolchain=//build/toolchain/host:linux_x64_gcc --directory /home/spang/connectedhomeip2/ --touch /home/spang/connectedhomeip2/out/host/gen/integrations/mobly/py/chip_mobly/pigweed_device.py.pylint.pw_pystamp --capture-output --module pylint -- integrations/mobly/py/chip_mobly/pigweed_device.py --jobs=1 --output-format=colorized
************* Module chip_mobly.pigweed_device
integrations/mobly/py/chip_mobly/pigweed_device.py:1:0: C0114: Missing module docstring (missing-module-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:32:0: C0115: Missing class docstring (missing-class-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:39:12: C0103: Variable name "m" doesn't conform to snake_case naming style (invalid-name)
integrations/mobly/py/chip_mobly/pigweed_device.py:43:4: C0116: Missing function or method docstring (missing-function-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:47:4: C0116: Missing function or method docstring (missing-function-docstring)
integrations/mobly/py/chip_mobly/pigweed_device.py:74:4: W0107: Unnecessary pass statement (unnecessary-pass)
integrations/mobly/py/chip_mobly/pigweed_device.py:18:0: C0411: standard import "import importlib" should be placed before "import serial" (wrong-import-order)
------------------------------------------------------------------
Your code has been rated at 8.06/10 (previous run: 8.06/10, +0.00)
ninja: build stopped: subcommand failed.
szatmz
force-pushed
the
pigweed-rollup
branch
from
c87ab64
to
fac2999
Compare
|
@mspang please try now |
|
szatmz
force-pushed
the
pigweed-rollup
branch
from
fac2999
to
6d5fb62
Compare
|
@mspang try again please |
mspang
approved these changes
Dec 3, 2020
Damian-Nordic
approved these changes
Dec 3, 2020
jelderton
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent Pigweed RPC changes are needed to support host-driven on-device testing.
Related PR: #3930
Summary of Changes
Rolling up third_party/pigweed/repo to a recent commit.