Fix DevicePairingDelegate::OnPairingComplete is not called if pairing code is wrong #36139
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
Evgeny Trushkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
PR #36139: Size comparison from 2574847 to 9607577 Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| mPairingDelegate->OnPairingComplete(status); | ||
| } | ||
| } | ||
| if (CHIP_NO_ERROR != status && mPairingDelegate != nullptr) |
There was a problem hiding this comment.
The actual behavior here is very complicated (e.g. if your pairing code is right but the device is not advertising that's the same situation as wrong pairing code!), and worse yet existing clients depend on it, so probably cannot be changed without breaking lots of shipping software.
The right answer here is that we should have a sane error reporting API, not what we have right now, but we should be extremely careful about any changes to the existing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
DevicePairingDelegate::OnStatusUpdate(Status::SecurePairingFailed)callback will be called in case of pairing device with wrong manual code. The signature of OnStatusUpdate() does not include CHIP_ERROR.Seems that the correct behavior is to call DevicePairingDelegate::OnPairingComplete(error) as well.
Error will likely hold
CHIP Error 0x00000032: Timeout.This way looking at
OnPairingComplete,OnCommissioningSuccessandOnCommissioningFailureis enough to keep track on commissioning process. And all of them provide CHIP_ERROR for diagnostics.