-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chef] Fix AirQualitySensor temperature range #35742
Merged
mergify
merged 1 commit into
project-chip:master
from
erwinpan1:fix_airqualitysensor_temperature_range
Sep 24, 2024
Merged
[Chef] Fix AirQualitySensor temperature range #35742
mergify
merged 1 commit into
project-chip:master
from
erwinpan1:fix_airqualitysensor_temperature_range
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original was setting maxMeasuredValue/maxMeasuredValue as 0x800 which doesn't make any senses. So it is modified to the reasonable values from -5000 (-50 celsius degrees) ~ 7000 (70 celsius degrees)
Review changes with SemanticDiff. |
erwinpan1
changed the title
Fix Chef AirQualitySensor temperature range
[Chef] Fix AirQualitySensor temperature range
Sep 24, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
September 24, 2024 11:22
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
turon,
tcarmelveilleux,
vivien-apple,
tecimovic,
wiba-nordic,
tehampson,
woody-apple,
tima-q,
younghak-hwang,
tobiasgraf,
yufengwangca and
yunhanw-google
September 24, 2024 11:22
PR #35742: Size comparison from fbc0d21 to 3ae8e65 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Sep 24, 2024
tcarmelveilleux
approved these changes
Sep 24, 2024
andy31415
approved these changes
Sep 24, 2024
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 25, 2024
The original was setting maxMeasuredValue/maxMeasuredValue as 0x800 which doesn't make any senses. So it is modified to the reasonable values from -5000 (-50 celsius degrees) ~ 7000 (70 celsius degrees)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original was setting
maxMeasuredValue
andmaxMeasuredValue
as0x800
which doesn't make any senses.Resolution
Set to the reasonable values from
-5000
(-50 celsius degrees) ~7000
(70 celsius degrees)