Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chef] Fix AirQualitySensor temperature range #35742

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[Chef] Fix AirQualitySensor temperature range #35742

merged 1 commit into from
Sep 24, 2024

Conversation

erwinpan1
Copy link
Contributor

Description

The original was setting maxMeasuredValue and maxMeasuredValue as 0x800 which doesn't make any senses.

Resolution

Set to the reasonable values from -5000 (-50 celsius degrees) ~ 7000 (70 celsius degrees)

@erwinpan1
Fix Chef AirQualitySensor temperature range
3ae8e65 
The original was setting maxMeasuredValue/maxMeasuredValue as 0x800
which doesn't make any senses. So it is modified to the reasonable
values from -5000 (-50 celsius degrees) ~ 7000 (70 celsius degrees)
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@erwinpan1 erwinpan1 changed the title Fix Chef AirQualitySensor temperature range [Chef] Fix AirQualitySensor temperature range Sep 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

PR #35742: Size comparison from fbc0d21 to 3ae8e65

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section fbc0d21 3ae8e65 change % change
bl602 lighting-app bl602 FLASH 1280488 1280488 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1294354 1294354 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1320438 1320438 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 944328 944328 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946728 946728 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039892 1039892 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646790 646790 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894604 894604 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960988 960988 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963610 963610 0 0.0
RAM 16964 16964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829356 829356 0 0.0
RAM 123300 123300 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814312 814312 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760396 760396 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 744632 744632 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616162 616162 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656058 656058 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677725 677725 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697569 697569 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697569 697569 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654513 654513 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613789 613789 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633425 633425 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633425 633425 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633013 633013 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652729 652729 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652729 652729 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608429 608429 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628289 628289 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628289 628289 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933292 933292 0 0.0
RAM 135884 135884 0 0.0
lock-app BRD2605a FLASH 740728 740720 -8 -0.0
RAM 231220 231220 0 0.0
BRD4338a FLASH 741376 741368 -8 -0.0
RAM 231252 231252 0 0.0
window-app BRD4187C FLASH 1016376 1016368 -8 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1537598 1537598 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548042 1548042 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2764623 2764623 0 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6068112 6068112 0 0.0
RAM 507360 507360 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5401444 5401444 0 0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4735064 4735064 0 0.0
RAM 218304 218304 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12546570 12546570 0 0.0
RAM 555090 555090 0 0.0
chip-tool-ipv6only arm64 unknown 20456 20456 0 0.0
FLASH 11204432 11204432 0 0.0
RAM 605336 605336 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 10908791 10908791 0 0.0
RAM 554234 554234 0 0.0
fabric-bridge-app debug unknown 4640 4640 0 0.0
FLASH 4561676 4561676 0 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5676033 5676033 0 0.0
RAM 228552 228552 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4784298 4784298 0 0.0
RAM 204376 204376 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4417388 4417388 0 0.0
RAM 198112 198112 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4556168 4556168 0 0.0
RAM 202680 202680 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3095405 3095405 0 0.0
RAM 159184 159184 0 0.0
thermostat-no-ble arm64 unknown 9432 9432 0 0.0
FLASH 4306728 4306728 0 0.0
RAM 242808 242808 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6013397 6013397 0 0.0
RAM 580896 580896 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10739869 10739869 0 0.0
RAM 642976 642976 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913412 913412 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885020 885020 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846920 846920 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581728 581728 0 0.0
RAM 70776 70776 0 0.0
k32w1+release FLASH 594344 594344 0 0.0
RAM 62944 62944 0 0.0
mcxw71+release FLASH 594096 594096 0 0.0
RAM 62944 62944 0 0.0
light k32w0+release FLASH 617780 617780 0 0.0
RAM 70248 70248 0 0.0
k32w1+release FLASH 680976 680976 0 0.0
RAM 48584 48584 0 0.0
mcxw71+release FLASH 680992 680992 0 0.0
RAM 48584 48584 0 0.0
lock k32w1+release FLASH 702952 702952 0 0.0
RAM 67084 67084 0 0.0
mcxw71+release FLASH 702976 702976 0 0.0
RAM 67084 67084 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645348 1645348 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551332 1551332 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467148 1467148 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463764 1463764 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 659488 659488 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 617388 617388 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481040 481040 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620046 620046 0 0.0
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687280 687280 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780214 780214 0 0.0
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 681050 681050 0 0.0
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 619808 619808 0 0.0
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707750 707750 0 0.0
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624772 624772 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810424 810424 0 0.0
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655596 655596 0 0.0
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 697026 697026 0 0.0
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633432 633432 0 0.0
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610622 610622 0 0.0
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467336 467336 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 626938 626938 0 0.0
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652758 652758 0 0.0
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637352 637352 0 0.0
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523538 523538 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4876 4876 0 0.0
FLASH 1722360 1722360 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10316 10316 0 0.0
FLASH 17350634 17350634 0 0.0
RAM 7559320 7559320 0 0.0

@mergify mergify bot merged commit 756b329 into project-chip:master Sep 24, 2024
69 checks passed
@erwinpan1 erwinpan1 deleted the fix_airqualitysensor_temperature_range branch September 25, 2024 01:09
erwinpan1 added a commit to erwinpan1/connectedhomeip that referenced this pull request Sep 25, 2024
@erwinpan1
Fix Chef AirQualitySensor temperature range (project-chip#35742)
cf0bc86 
The original was setting maxMeasuredValue/maxMeasuredValue as 0x800
which doesn't make any senses. So it is modified to the reasonable
values from -5000 (-50 celsius degrees) ~ 7000 (70 celsius degrees)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@andy31415 andy31415 Awaiting requested review from andy31415

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@tehampson tehampson Awaiting requested review from tehampson

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erwinpan1 @tcarmelveilleux @andy31415 @tehampson