-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move management of uniqueIdentifier into MTRDeviceController base class. #35491
Open
bzbarsky-apple
wants to merge
1
commit into
project-chip:master
Choose a base branch
from
bzbarsky-apple:uniqueIdentifier-base-class
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move management of uniqueIdentifier into MTRDeviceController base class. #35491
bzbarsky-apple
wants to merge
1
commit into
project-chip:master
from
bzbarsky-apple:uniqueIdentifier-base-class
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #35491: Size comparison from 2e5b709 to e17fa38 Full report (3 builds for nxp, stm32)
|
e17fa38
to
9ebd5e9
Compare
PR #35491: Size comparison from 2e5b709 to 9ebd5e9 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Sep 9, 2024
woody-apple
reviewed
Sep 9, 2024
woody-apple
reviewed
Sep 9, 2024
7eb861f
to
6dfba51
Compare
6dfba51
to
98000ce
Compare
PR #35491: Size comparison from 3d3784e to 98000ce Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
98000ce
to
11bbf46
Compare
PR #35491: Size comparison from b8898ab to 11bbf46 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.