Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lgtm.yaml #3362

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Oct 21, 2020

Problem

We're no longer using lgtm.com but have a configuration file for it.

Summary of Changes

Delete lgtm.yaml

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.rodata 12 12
chip-wifi-echo.elf .dram0.bss 0 8
chip-wifi-echo.elf .dram0.data 8 8
chip-wifi-echo.elf .flash.text -84 -84
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.flash.rodata,12,12
.dram0.bss,8,0
.dram0.data,8,8
.debug_loc,0,-4
[Unmapped],0,-20
.flash.text,-84,-84


@andy31415
Copy link
Contributor

I am very puzzled about our bloat checker - how in the world would this PR change flash/rodata size. I wonder if our builds are really reproducible or we properly detect where we branch off master.

@andy31415 andy31415 merged commit 47dca34 into project-chip:master Oct 21, 2020
@mspang mspang deleted the for-chip/remove-lgtm-yaml branch April 2, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants