-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example app for the EFR32 #321
Conversation
This is based on the OW lock example. It does not depend on OpenThread right now so a lot of the Makefile differences between the OW example and this come from having to build the EFR32 platform since it's not being provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending comments, but LGTM
@pierredelisle & @suryanshup - any update? |
@BroderickCarlin @jelderton can you take a peek please? @gerickson - can we get eyes on this today so we can make progress? |
I pinged @suryanshup again. |
Agreed. Other LEDs don't signal any runtime state yet (could be used in
future). They do participate when the factory reset sequence is triggered.
…On Mon, Apr 13, 2020 at 1:41 PM Sagar Dhawan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/lock-app/efr32/src/AppTask.cpp
<#321 (comment)>
:
> + if (aEvent->Type != AppEvent::kEventType_Timer)
+ {
+ return;
+ }
+
+ // If we reached here, the button was held past FACTORY_RESET_TRIGGER_TIMEOUT, initiate factory reset
+ if (sAppTask.mFunctionTimerActive && sAppTask.mFunction == kFunction_SoftwareUpdate)
+ {
+ EFR32_LOG("Factory Reset Triggered. Release button within %ums to cancel.", FACTORY_RESET_TRIGGER_TIMEOUT);
+
+ // Start timer for FACTORY_RESET_CANCEL_WINDOW_TIMEOUT to allow user to cancel, if required.
+ sAppTask.StartTimer(FACTORY_RESET_CANCEL_WINDOW_TIMEOUT);
+
+ sAppTask.mFunction = kFunction_FactoryReset;
+
+ // Turn off all LEDs before starting blink to make sure blink is co-ordinated.
Okay, sounds good. @suryanshup <https://github.com/suryanshup> looks like
this code will have to handle both types of boards. The other LEDs don't
signal any runtime state.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALZUJMETXZM2VJFHTQYXRZLRMN2GRANCNFSM4ME6FEEA>
.
|
Thanks for confirming and updating the code.
…On Mon, Apr 13, 2020 at 2:16 PM Sagar Dhawan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/lock-app/efr32/src/AppTask.cpp
<#321 (comment)>
:
> +
+ sAppTask.mFunction = kFunction_SoftwareUpdate;
+ }
+ }
+ else
+ {
+ // If the button was released before factory reset got initiated, trigger a software update.
+ if (sAppTask.mFunctionTimerActive && sAppTask.mFunction == kFunction_SoftwareUpdate)
+ {
+ sAppTask.CancelTimer();
+ EFR32_LOG("Software Update is not supported at this time");
+ }
+ else if (sAppTask.mFunctionTimerActive && sAppTask.mFunction == kFunction_FactoryReset)
+ {
+ // Set lock status LED back to show state of lock.
+ sLockLED.Set(sLEDState);
@suryanshup <https://github.com/suryanshup>, I just checked the SiLabs
documentation and confirmed that the none of the EFR32 boards have more
than 2 LEDs. I've updated the latest commit to reflect that by removing the
spurious BSP_LED_X defines.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALZUJMBNULA2XM3LJPYY55DRMN6J7ANCNFSM4ME6FEEA>
.
|
…analysis stage" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/code_size_stage to silabs_1.0 Squashed commit of the following: commit 8aeddeb628aa63f92e892b36f417afcffc6fbe79 Author: Rehan Rasool <Rehan.Rasool@silabs.com> Date: Mon Nov 21 14:58:21 2022 +0000 Pull request project-chip#309: Update and fix code size analysis stage Merge in WMN_TOOLS/matter from bugfix/code_size_stage to silabs Squashed commit of the following: commit f29119eab4419dec78466f4e2d73f6884e5b6826 Author: Rehan Rasool <rehan.rasool@silabs.com> Date: Fri Nov 18 19:50:48 2022 -0500 Enable for silabs, silabs_1.0 and RC branches commit 83c227b23ed443103820c638171fd12be73e44fc Author: Rehan Rasool <rehan.rasool@silabs.com> Date: Fri Nov 18 19:47:55 2022 -0500 Revert "Temporarily comment out unnecessary stages to speed up code size analysis verification" This reverts commit 5af856bd5a10887365e7affcf379d1de4c08a405. commit 1ba2f9c37e763d212831ce6678f1bd216ba04393 Author: Rehan Rasool <rehan.rasool@silabs.com> Date: Fri Nov 18 19:11:36 2022 -0500 Fix code size analysis wi-fi app path to newer name ... and 2 more commits (cherry picked from commit 6a5a29379a86d46da332a7db92ecf0e7c90b1c12)
Problem
No way to exercise the EFR32 platform specific code.
Summary of Changes
Add an example app for the EFR32 with instructions on how to build it.
Currently the CHIP stack is very limited but this app is able to launch with CHIP linked and use some of the features that are implemented for now.
We are working with the SDK authors on making this app easier to build.