-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build of esp32-m5stack-all-clusters-rpc-ipv6only
for out of tree PW_ENVIRONMENT_ROOT
#30473
Merged
mergify
merged 6 commits into
project-chip:master
from
andy31415:fix_absolute_path_logic
Nov 15, 2023
Merged
Fix build of esp32-m5stack-all-clusters-rpc-ipv6only
for out of tree PW_ENVIRONMENT_ROOT
#30473
mergify
merged 6 commits into
project-chip:master
from
andy31415:fix_absolute_path_logic
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
November 14, 2023 18:26
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 14, 2023 18:26
I believe general CI will not catch this because PW_ENVIRONMENT_ROOT will not be set. So it would catch only if I mis-set something. However anything building in |
PR #30473: Size comparison from 0f6b1fc to eed1083 Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
tehampson
approved these changes
Nov 14, 2023
PR #30473: Size comparison from 0f6b1fc to 8959454 Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
mspang
approved these changes
Nov 14, 2023
This reverts commit ace3514.
PR #30473: Size comparison from 0f6b1fc to 5cc9c97 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Nov 15, 2023
…t of tree PW_ENVIRONMENT_ROOT (project-chip#30473)" This reverts commit 27328ae.
andy31415
added a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In google/pigweed@ddbc9fc pigweed started using
pw_env_setup_CIPD_PIGWEED
however our examples was not really setting this up correctly for out-of-tree pigweed environment root (such as the vscode one). Pigweed auto-generatesbuild_overrides/pigweed_environment.gni
and our examples scripts tried to rebase those paths, however the rebase is invalid when the paths are relative (like saying//../home/vscode/pwenv
when working in/workspace
)Fixes #30475
Changes:
//../
prefix as an indicator of relative paths and then work around that by adding extra relative paths (I could not find a way to find out the right path here !)Tested: