-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for recognizing and validating Network Identity certs #30114
Add basic support for recognizing and validating Network Identity certs #30114
Conversation
00e440b
to
31e9a75
Compare
PR #30114: Size comparison from 739f72a to 31e9a75 Increases (22 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, psoc6)
Decreases (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
This involves changing some Extract*FromCert methods from using ChipCertificateSet to load the certificate to just using DecodeChipCert, since ChipCertificateSet makes additional assumptions. Also remove unused ChipCertificateData.mCertificate member
31e9a75
to
6ba6285
Compare
PR #30114: Size comparison from 739f72a to 6ba6285 Increases (34 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6)
Decreases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please better document the non-standard public key crypto used here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending comments from @tcarmelveilleux
PR #30114: Size comparison from 739f72a to 43fdbcf Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (25 builds for bl702, bl702l, cc32xx, linux, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This involves changing some Extract*FromCert methods from using ChipCertificateSet to load the certificate to just using DecodeChipCert, since ChipCertificateSet makes additional assumptions.
Also remove unused ChipCertificateData.mCertificate member and make BitFlags more constexpr friendly.
Part of #29856