Add basic support for recognizing and validating Network Identity certs #30114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
ksperling-apple
force-pushed
the
pdc-network-identity
branch
from
00e440b
to
31e9a75
Compare
|
PR #30114: Size comparison from 739f72a to 31e9a75 Increases (22 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, psoc6)
Decreases (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
This involves changing some Extract*FromCert methods from using ChipCertificateSet to load the certificate to just using DecodeChipCert, since ChipCertificateSet makes additional assumptions. Also remove unused ChipCertificateData.mCertificate member
ksperling-apple
force-pushed
the
pdc-network-identity
branch
from
31e9a75
to
6ba6285
Compare
|
PR #30114: Size comparison from 739f72a to 6ba6285 Increases (34 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6)
Decreases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
requested changes
Oct 31, 2023
woody-apple
approved these changes
Oct 31, 2023
tcarmelveilleux
approved these changes
Nov 1, 2023
|
PR #30114: Size comparison from 739f72a to 43fdbcf Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (25 builds for bl702, bl702l, cc32xx, linux, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves changing some Extract*FromCert methods from using ChipCertificateSet to load the certificate to just using DecodeChipCert, since ChipCertificateSet makes additional assumptions.
Also remove unused ChipCertificateData.mCertificate member and make BitFlags more constexpr friendly.
Part of #29856