Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Smoke CO Alarm #27123

Merged
merged 27 commits into from
Jul 21, 2023
Merged

Add tests for Smoke CO Alarm #27123

merged 27 commits into from
Jul 21, 2023

Conversation

ericzijian1994
Copy link
Contributor

@ericzijian1994 ericzijian1994 commented Jun 7, 2023 •
edited
Loading

bzbarsky-apple
bzbarsky-apple reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the event bits as you have them here, but file a follow-up issue to do something better. We really can't depend on real devices not having random other events going on...

src/app/tests/suites/certification/Test_TC_SMCO_1_1.yaml Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_2.yaml Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_4.yaml Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_4.yaml Outdated Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_4.yaml Outdated Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_5.yaml Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_5.yaml Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_6.yaml Outdated Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_6.yaml Outdated Show resolved Hide resolved
src/app/tests/suites/certification/Test_TC_SMCO_2_6.yaml Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so this is not blocked on me, but:

  1. Please make sure the problem about expressed state is reflected in the test plan issue.
  2. Please fix the backwards PICS for the WaitForMs.

@mhazley
Copy link
Contributor

mhazley commented Jul 21, 2023

Generally, test plan step numbers in the YAML would help with following these!

@mergify mergify bot merged commit 47cfe96 into project-chip:master Jul 21, 2023
48 checks passed
@ericzijian1994 ericzijian1994 deleted the smco_tests branch July 25, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhazley mhazley mhazley left review comments

@cecille cecille cecille left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@hicklin hicklin Awaiting requested review from hicklin

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@jjm202 jjm202 Awaiting requested review from jjm202

@hare-siterwell hare-siterwell Awaiting requested review from hare-siterwell

Assignees
No one assigned
Labels
app darwin examples fast track review - pending scripts tests
Projects
[Device Type] Smoke & CO
Status: Done
[Platform] Darwin
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@ericzijian1994 @bzbarsky-apple @hare-siterwell @jamesliresideo @woody-apple @mhazley @cecille @jjm202 @restyled-commits