-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherry-pick]Inet implementations assume BYTE_ORDER is defined. make sure that it … #26615
Merged
andy31415
merged 1 commit into
project-chip:v1.1-branch
from
jmartinez-silabs:cherry-pick/byte_order_fix
May 16, 2023
Merged
[Cherry-pick]Inet implementations assume BYTE_ORDER is defined. make sure that it … #26615
andy31415
merged 1 commit into
project-chip:v1.1-branch
from
jmartinez-silabs:cherry-pick/byte_order_fix
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is (project-chip#26460) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #26615: Size comparison from ec11881 to 207260a Increases (25 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, psoc6, qpg, telink)
Decreases (9 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick to v1.1-branch
…is (#26460)
BYTE_ORDER must be defined in the project
fix typo
Remove BYTE_ORDER from the file. Only use BYTE_ORDER and relative checks
Apply suggestions from code review