Add Concentration Measurement Cluster Definition #26525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rement-cluster-definition
|
PR #26525: Size comparison from 023b023 to 7a300f6 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
There was a problem hiding this comment.
You probably need #26478 to merge before this will pass CI....
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
… 26225-add-concentration-measurement-cluster-definition
Should match spec
Adding „Concentration“ to the cluster name. This naming convention maintains the integrity of the base cluster's name while also specifying the unique substance that the aliased version pertains to.
… 26225-add-concentration-measurement-cluster-definition # Conflicts: # src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java
|
PR #26525: Size comparison from aada43c to 545c078 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
|
PR #26525: Size comparison from 5f1a60b to c13f062 Increases above 0.2%:
Increases (17 builds for bl702, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc32xx, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
…r-definition # Conflicts: # src/app/zap_cluster_list.json # src/controller/data_model/BUILD.gn # src/controller/data_model/controller-clusters.matter # zzz_generated/darwin/controller-clusters/zap-generated/endpoint_config.h
AVG_MEASURED_VALUE_WINDOW and PEAK_MEASURED_VALUE_WINDOW are using elapsed_s as per spec.
|
PR #26525: Size comparison from bfa0580 to dc14bba Increases above 0.2%:
Increases (6 builds for bl602, bl702, cc32xx, linux)
Decreases (1 build for cc32xx)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
|
PR #26525: Size comparison from bfa0580 to ccb1514 Increases above 0.2%:
Increases (17 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (15 builds for cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Lines were added twice due to poor merging 🙁
|
PR #26525: Size comparison from bfa0580 to ef93df3 Increases above 0.2%:
Increases (15 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (12 builds for cc32xx, efr32, esp32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26525: Size comparison from cbd5dac to f897c68 Increases above 0.2%:
Increases (21 builds for bl702, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, cc32xx, efr32, esp32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26525: Size comparison from 853691d to 41c386d Increases above 0.2%:
Increases (18 builds for bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (17 builds for bl602, bl702, cc32xx, efr32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…r-definition # Conflicts: # src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java # zzz_generated/darwin/controller-clusters/zap-generated/CHIPClientCallbacks.h # zzz_generated/darwin/controller-clusters/zap-generated/CHIPClusters.h # zzz_generated/darwin/controller-clusters/zap-generated/endpoint_config.h # zzz_generated/darwin/controller-clusters/zap-generated/gen_config.h
|
PR #26525: Size comparison from ad5253a to 0f165a1 Increases above 0.2%:
Increases (9 builds for bl702, cc32xx, linux, nrfconnect, psoc6)
Decreases (11 builds for bl602, bl702, cc32xx, efr32, nrfconnect, psoc6)
Full report (28 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
hicklin
reviewed
May 26, 2023
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
hicklin
approved these changes
May 26, 2023
hicklin
approved these changes
May 26, 2023
mhazley
approved these changes
May 26, 2023
mhazley
approved these changes
May 26, 2023
Rename VOC_CONCENTRATION_MEASUREMENT_CLUSTER to TVOC_CONCENTRATION_MEASUREMENT_CLUSTER
|
PR #26525: Size comparison from e00843e to 1ad07c0 Increases above 0.2%:
Increases (23 builds for bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, esp32, linux, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tobiasgraf
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR adds the concentration measurement cluster definition (
concentration-measurement-cluster.xml) zap template.🔎 Details
zap_regen_all.py☝️ The template is based on a in-progress version of the spec, not current master. Its based on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6568
🧪 How Has This Been Tested
./scripts/examples/gn_build_example.sh examples/chip-tool out/chip-tool🔗 Links/References