Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: chip_tool_guide: style and consistency edits #25731

Merged
merged 2 commits into from
Mar 22, 2023
Merged

doc: chip_tool_guide: style and consistency edits #25731

merged 2 commits into from
Mar 22, 2023

Conversation

greg-fer
Copy link
Contributor

Edited the CHIP Tool guide for style and structure consistency.
Edits aim only at style, language, formatting, without affecting contents.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 17, 2023
@github-actions
Copy link

PR #25731: Size comparison from 379cde1 to e800fab

Full report (1 build for cc32xx)
platform target config section 379cde1 e800fab change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 2024602 2024602 0 0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Mar 17, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
@greg-fer
Copy link
Contributor Author

@bzbarsky-apple , kindly please check the new commit with edits.

bzbarsky-apple
bzbarsky-apple approved these changes Mar 21, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
@greg-fer greg-fer mentioned this pull request Mar 22, 2023
Open
@greg-fer greg-fer force-pushed the doc_chip_tool_guide_edits branch 2 times, most recently from 8327f10 to 23d00f4 Compare March 22, 2023 08:00
@github-actions
Copy link

PR #25731: Size comparison from 2a9fa2a to 23d00f4

Decreases (1 build for cc32xx)
platform target config section 2a9fa2a 23d00f4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248022 20248021 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 2a9fa2a 23d00f4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248022 20248021 -1 -0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@github-actions
Copy link

PR #25731: Size comparison from 2a9fa2a to 6136cf4

Decreases (1 build for cc32xx)
platform target config section 2a9fa2a 6136cf4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248022 20248021 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 2a9fa2a 6136cf4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248022 20248021 -1 -0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

kkasperczyk-no
kkasperczyk-no approved these changes Mar 22, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
@greg-fer greg-fer force-pushed the doc_chip_tool_guide_edits branch 2 times, most recently from 71b02a6 to bcf3435 Compare March 22, 2023 11:25
@greg-fer
doc: chip_tool_guide: style and consistency edits
6d114ca 
Edited the CHIP Tool guide for style and structure consistency.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
@github-actions
Copy link

PR #25731: Size comparison from 47a216d to 2fdfeb7

Increases (1 build for cc32xx)
platform target config section 47a216d 2fdfeb7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248021 20248023 2 0.0
Full report (1 build for cc32xx)
platform target config section 47a216d 2fdfeb7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248021 20248023 2 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@kkasperczyk-no kkasperczyk-no enabled auto-merge (squash) March 22, 2023 14:08
@kkasperczyk-no kkasperczyk-no merged commit 6be032d into project-chip:master Mar 22, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@greg-fer @restyled-commits
doc: chip_tool_guide: style and consistency edits (project-chip#25731)
c82f20f 
* doc: chip_tool_guide: style and consistency edits

Edited the CHIP Tool guide for style and structure consistency.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>

* Restyled by prettier-markdown

---------

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
Co-authored-by: Restyled.io <commits@restyled.io>
@greg-fer greg-fer mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg-fer @bzbarsky-apple @kkasperczyk-no @restyled-commits