[Ameba] Dynamic logging #25273
Merged
[Ameba] Dynamic logging #25273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankore
commented
Feb 23, 2023
pankore
commented
- create an interface to set logging levels
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
kkasperczyk-no
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
bzbarsky-apple
approved these changes
Feb 23, 2023
andy31415
reviewed
Feb 24, 2023
andy31415
reviewed
Feb 24, 2023
andy31415
reviewed
Feb 24, 2023
andy31415
reviewed
Feb 28, 2023
andy31415
approved these changes
Feb 28, 2023
- change namespace
andy31415
reviewed
Mar 1, 2023
andy31415
reviewed
Mar 1, 2023
- change enum class name
- change back the namespace to chip::Logging::Platform
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [logging] dynamic log level setting * [logging] cleaup * [logging] use enums instead of macros * [logging] cleanup * [logging] change loglevel to enum class - change namespace * [logging] use to_underlying - change enum class name * [logging] fix compile errors - change back the namespace to chip::Logging::Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.