Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matter_idl] Add to flake8 in workflow and fix python files (part #25193) #25272

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

DamMicSzm
Copy link
Contributor

This pull request is a part of #25193 ( part fix python files in Matter_idl )

Problem

Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.

Changes

Fix all python files in Matter_idl where linter find problem. Adding Matter_idl to check with flake8.

Testing

CI will test and maybe some another manual testing

@github-actions
Copy link

PR #25272: Size comparison from 7e728bc to 70ce16b

Decreases (1 build for cc32xx)
platform target config section 7e728bc 70ce16b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20249763 20249762 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 7e728bc 70ce16b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642569 642569 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930138 930138 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299764 299764 0 0.0
.debug_info 20249763 20249762 -1 -0.0
.debug_line 2655140 2655140 0 0.0
.debug_loc 2795460 2795460 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3018033 3018033 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377761 377761 0 0.0
.symtab 256256 256256 0 0.0
.text 534628 534628 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a992882 into project-chip:master Feb 24, 2023
@DamMicSzm DamMicSzm deleted the flake8-fix-matter-idl branch February 24, 2023 09:43
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants