Place IMGUI UIs into a separate common module #25131

andy31415 · 2023-02-16T18:36:57Z

This allows any app to add UIs on linux and mac. Specifically any app can add a QR code for sure and then we can develop various cluster views as needed.

This does not add new functionality, just makes things more modular.

src/app/util/types_stub.h

examples/common/imgui_ui/windows/light.cpp

examples/common/imgui_ui/ui.cpp

github-actions · 2023-02-16T21:12:09Z

PR #25131: Size comparison from c32ca61 to 6471755

Increases (5 builds for bl602, bl702, cc32xx)

platform	target	config	section	`c32ca61`	`6471755`	change
bl602	lighting-app	bl602	.text	1025366	1025368	2
		bl602+rpc	.text	`1056042`	1056044	2
bl702	lighting-app	bl702	.debug_info	40664853	40664854	1
			.text	954764	954766	2
		bl702+rpc	(read/write)	1280607	1280623	16
			.debug_info	45074209	45074211	2
			.text	1032158	1032162	4
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20347053	20347055	2

Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)

platform	target	config	section	`c32ca61`	`6471755`	change
bl602	lighting-app	bl602	(read/write)	1349102	1349102	0
			.bss	94834	94834	0
			.data	9736	9736	0
			.text	1025366	1025368	2
		bl602+rpc	(read/write)	1394270	1394270	0
			.bss	102882	102882	0
			.data	10128	10128	0
			.text	`1056042`	1056044	2
bl702	lighting-app	bl702		0	0	0
			(read only)	3358	3358	0
			(read/write)	1187451	1187451	0
			.bleromro	6342	6342	0
			.bleromrw	124	124	0
			.boot2	292	292	0
			.bss	69937	69937	0
			.bss_psram	30064	30064	0
			.comment	48	48	0
			.data	4056	4056	0
			.debug_abbrev	1552964	1552964	0
			.debug_aranges	134384	134384	0
			.debug_frame	492440	492440	0
			.debug_info	40664853	40664854	1
			.debug_line	5282334	5282334	0
			.debug_loc	`3414245`	`3414245`	0
			.debug_ranges	372192	372192	0
			.debug_str	3575377	3575377	0
			.hbn	536	536	0
			.hbn_noinit	260	260	0
			.init	342	342	0
			.init_array	144	144	0
			.psram	0	0	0
			.riscv.attributes	47	47	0
			.rodata	107552	107552	0
			.rsvd	2960	2960	0
			.sha_ocram	72	72	0
			.shstrtab	304	304	0
			.stack	2048	2048	0
			.strtab	574023	574023	0
			.symtab	173584	173584	0
			.tcm_data	36	36	0
			.tcmcode	3358	3358	0
			.text	954764	954766	2
		bl702+rpc		0	0	0
			(read only)	3358	3358	0
			(read/write)	1280607	1280623	16
			.bleromro	6342	6342	0
			.bleromrw	124	124	0
			.boot2	292	292	0
			.bss	77985	77985	0
			.bss_psram	30320	30320	0
			.comment	48	48	0
			.data	4608	4608	0
			.debug_abbrev	1701454	1701454	0
			.debug_aranges	142616	142616	0
			.debug_frame	520188	520188	0
			.debug_info	45074209	45074211	2
			.debug_line	5681330	5681330	0
			.debug_loc	3611163	3611163	0
			.debug_ranges	395960	395960	0
			.debug_str	3978881	3978881	0
			.hbn	536	536	0
			.hbn_noinit	260	260	0
			.init	342	342	0
			.init_array	160	160	0
			.psram	0	0	0
			.riscv.attributes	47	47	0
			.rodata	122192	122192	0
			.rsvd	2960	2960	0
			.sha_ocram	72	72	0
			.shstrtab	304	304	0
			.stack	2048	2048	0
			.strtab	635082	635082	0
			.symtab	192048	192048	0
			.tcm_data	36	36	0
			.tcmcode	3358	3358	0
			.text	1032158	1032162	4
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	641857	641857	0
			(read/write)	204124	204124	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197528	197528	0
			.comment	194	194	0
			.data	1476	1476	0
			.debug_abbrev	931515	931515	0
			.debug_aranges	87464	87464	0
			.debug_frame	300232	300232	0
			.debug_info	20347053	20347055	2
			.debug_line	2658245	2658245	0
			.debug_loc	2791387	2791387	0
			.debug_ranges	281600	281600	0
			.debug_str	3015122	3015122	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105697	105697	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	376514	376514	0
			.symtab	256016	256016	0
			.text	534036	534036	0
linux	chip-tool-ipv6only	arm64	(read only)	12050772	12050772	0
			(read/write)	729208	729208	0
			.bss	34248	34248	0
			.data	3008	3008	0
			.data.rel.ro	671424	671424	0
			.dynamic	560	560	0
			.got	15328	15328	0
			.init	24	24	0
			.init_array	208	208	0
			.rodata	585300	585300	0
			.text	9735204	9735204	0
	thermostat-no-ble	arm64	(read only)	2517204	2517204	0
			(read/write)	145320	145320	0
			.bss	56488	56488	0
			.data	1824	1824	0
			.data.rel.ro	77544	77544	0
			.dynamic	560	560	0
			.got	5408	5408	0
			.init	24	24	0
			.init_array	432	432	0
			.rodata	151232	151232	0
			.text	2103680	2103680	0
qpg	lighting-app	qpg6105+debug	(read/write)	1150556	1150556	0
			.bss	99932	99932	0
			.data	848	848	0
			.text	597656	597656	0
	lock-app	qpg6105+debug	(read/write)	1117820	1117820	0
			.bss	96428	96428	0
			.data	860	860	0
			.text	564916	564916	0

github-actions · 2023-02-16T22:30:38Z

PR #25131: Size comparison from c32ca61 to 7a9f3b2

Increases (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`7a9f3b2`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_loc	2791387	2791404	17	0.0

Decreases (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`7a9f3b2`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_abbrev	931515	930151	-1364	-0.1
			.debug_info	20347053	20330253	-16800	-0.1
			.debug_line	2658245	2658243	-2	-0.0
			.debug_str	3015122	3015052	-70	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`7a9f3b2`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	641857	641857	0	0.0
			(read/write)	204124	204124	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197528	197528	0	0.0
			.comment	194	194	0	0.0
			.data	1476	1476	0	0.0
			.debug_abbrev	931515	930151	-1364	-0.1
			.debug_aranges	87464	87464	0	0.0
			.debug_frame	300232	300232	0	0.0
			.debug_info	20347053	20330253	-16800	-0.1
			.debug_line	2658245	2658243	-2	-0.0
			.debug_loc	2791387	2791404	17	0.0
			.debug_ranges	281600	281600	0	0.0
			.debug_str	3015122	3015052	-70	-0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105697	105697	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	376514	376514	0	0.0
			.symtab	256016	256016	0	0.0
			.text	534036	534036	0	0.0

…dates

github-actions · 2023-02-16T22:55:03Z

PR #25131: Size comparison from c32ca61 to 1c2a2fb

Increases (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`1c2a2fb`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_loc	2791387	2791404	17	0.0

Decreases (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`1c2a2fb`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_abbrev	931515	930151	-1364	-0.1
			.debug_info	20347053	20330255	-16798	-0.1
			.debug_line	2658245	2658243	-2	-0.0
			.debug_str	3015122	3015052	-70	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`c32ca61`	`1c2a2fb`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	641857	641857	0	0.0
			(read/write)	204124	204124	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197528	197528	0	0.0
			.comment	194	194	0	0.0
			.data	1476	1476	0	0.0
			.debug_abbrev	931515	930151	-1364	-0.1
			.debug_aranges	87464	87464	0	0.0
			.debug_frame	300232	300232	0	0.0
			.debug_info	20347053	20330255	-16798	-0.1
			.debug_line	2658245	2658243	-2	-0.0
			.debug_loc	2791387	2791404	17	0.0
			.debug_ranges	281600	281600	0	0.0
			.debug_str	3015122	3015052	-70	-0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105697	105697	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	376514	376514	0	0.0
			.symtab	256016	256016	0	0.0
			.text	534036	534036	0	0.0

examples/common/imgui_ui/ui.cpp

github-actions · 2023-02-17T16:14:15Z

PR #25131: Size comparison from d684ecc to d219ead

Full report (1 build for cc32xx)

platform	target	config	section	`d684ecc`	d219ead6
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642473	642473
			(read/write)	203784	203784
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197184	197184
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	934705	934705
			.debug_aranges	87536	87536
			.debug_frame	300464	300464
			.debug_info	20372650	20372650
			.debug_line	2662287	2662287
			.debug_loc	2797042	2797042
			.debug_ranges	281936	281936
			.debug_str	3021415	3021415
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105705	105705
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377819	377819
			.symtab	256352	256352
			.text	534648	534648

…ents

* Modularize imgui - split windows and ready to add into any app * Comment update * Added extra assert * Switch to using a work scheduler instead of a stack lock for state updates * Restyle * typo fix * Update to sem_wait * Restyle * Generate shutdown event before stoppign the event loop task * Restyle * Update the code to not reference Server (would not compile otherwise) * Use a semaphore to wait for UI to send the shutdown. Also update comments * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>

Modularize imgui - split windows and ready to add into any app

6471755

andy31415 commented Feb 16, 2023

View reviewed changes

src/app/util/types_stub.h Outdated Show resolved Hide resolved

andy31415 commented Feb 16, 2023

View reviewed changes

examples/common/imgui_ui/windows/light.cpp Outdated Show resolved Hide resolved

bzbarsky-apple reviewed Feb 16, 2023

View reviewed changes

examples/common/imgui_ui/ui.cpp Outdated Show resolved Hide resolved

examples/common/imgui_ui/ui.cpp Outdated Show resolved Hide resolved

examples/common/imgui_ui/ui.cpp Show resolved Hide resolved

github-actions bot added app examples labels Feb 16, 2023

andy31415 added 2 commits February 16, 2023 17:03

Comment update

6488389

Added extra assert

7a9f3b2

andy31415 added 2 commits February 16, 2023 17:41

Switch to using a work scheduler instead of a stack lock for state up…

b59312a

…dates

Restyle

1c2a2fb

bzbarsky-apple reviewed Feb 17, 2023

View reviewed changes

examples/common/imgui_ui/ui.cpp Outdated Show resolved Hide resolved

examples/common/imgui_ui/ui.cpp Outdated Show resolved Hide resolved

andreilitvin added 6 commits February 17, 2023 09:19

typo fix

665b11e

Update to sem_wait

75f8447

Restyle

551e706

Merge branch 'master' into modular_ui

294d3f3

Generate shutdown event before stoppign the event loop task

7eb0ffa

Restyle

583ca0e

github-actions bot removed the app label Feb 17, 2023

tcarmelveilleux approved these changes Feb 17, 2023

View reviewed changes

Update the code to not reference Server (would not compile otherwise)

d219ead

bzbarsky-apple approved these changes Feb 17, 2023

View reviewed changes

examples/common/imgui_ui/ui.cpp Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels Feb 17, 2023

andy31415 added 2 commits February 17, 2023 12:30

Use a semaphore to wait for UI to send the shutdown. Also update comm…

a353c31

…ents

Restyle

ca278e8

andy31415 merged commit 6e82863 into project-chip:master Feb 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Place IMGUI UIs into a separate common module #25131

Place IMGUI UIs into a separate common module #25131

andy31415 commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

Place IMGUI UIs into a separate common module #25131

Place IMGUI UIs into a separate common module #25131

Conversation

andy31415 commented Feb 16, 2023 • edited Loading

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

andy31415 commented Feb 16, 2023 •

edited

Loading