-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place IMGUI UIs into a separate common module #25131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 16, 2023 18:37
andy31415
commented
Feb 16, 2023
andy31415
commented
Feb 16, 2023
PR #25131: Size comparison from c32ca61 to 6471755 Increases (5 builds for bl602, bl702, cc32xx)
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
|
PR #25131: Size comparison from c32ca61 to 7a9f3b2 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25131: Size comparison from c32ca61 to 1c2a2fb Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Feb 17, 2023
bzbarsky-apple
approved these changes
Feb 17, 2023
PR #25131: Size comparison from d684ecc to d219ead Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Modularize imgui - split windows and ready to add into any app * Comment update * Added extra assert * Switch to using a work scheduler instead of a stack lock for state updates * Restyle * typo fix * Update to sem_wait * Restyle * Generate shutdown event before stoppign the event loop task * Restyle * Update the code to not reference Server (would not compile otherwise) * Use a semaphore to wait for UI to send the shutdown. Also update comments * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any app to add UIs on linux and mac. Specifically any app can add a QR code for sure and then we can develop various cluster views as needed.
This does not add new functionality, just makes things more modular.