Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default gn_build.sh on M1/M2 macs. #24927

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Fix default gn_build.sh on M1/M2 macs. #24927

merged 3 commits into from
Feb 10, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

There is no "host clang" (i.e. pigweed clang) there.

Fixes #24609

@github-actions github-actions bot added the gn label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24927: Size comparison from fd3217a to 0b2777e

Decreases (1 build for cc32xx)
platform target config section fd3217a 0b2777e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194648 20194646 -2 -0.0
Full report (1 build for cc32xx)
platform target config section fd3217a 0b2777e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194648 20194646 -2 -0.0
.debug_line 2649781 2649781 0 0.0
.debug_loc 2785870 2785870 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001804 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24927: Size comparison from c6dab5e to 5dd4888

Full report (1 build for cc32xx)
platform target config section c6dab5e 5dd4888 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194647 20194647 0 0.0
.debug_line 2649781 2649781 0 0.0
.debug_loc 2785870 2785870 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001804 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24927: Size comparison from d6bb8c2 to e8838b5

Decreases (1 build for cc32xx)
platform target config section d6bb8c2 e8838b5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194648 20194646 -2 -0.0
Full report (1 build for cc32xx)
platform target config section d6bb8c2 e8838b5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194648 20194646 -2 -0.0
.debug_line 2649781 2649781 0 0.0
.debug_loc 2785870 2785870 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001804 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

jtung-apple
jtung-apple approved these changes Feb 9, 2023
View reviewed changes
BUILD.gn Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24927: Size comparison from d6bb8c2 to c370110

Increases (1 build for cc32xx)
platform target config section d6bb8c2 c370110 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
Decreases (1 build for cc32xx)
platform target config section d6bb8c2 c370110 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194648 20194395 -253 -0.0
.debug_str 3001804 3001474 -330 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section d6bb8c2 c370110 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194648 20194395 -253 -0.0
.debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001474 -330 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464576 2464576 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427220 1427220 0 0.0

@github-actions
Copy link

PR #24927: Size comparison from 36735ed to 06fe236

Increases (1 build for cc32xx)
platform target config section 36735ed 06fe236 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194395 20194396 1 0.0
Full report (1 build for cc32xx)
platform target config section 36735ed 06fe236 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194395 20194396 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 5ad70f6 into project-chip:master Feb 10, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-default-mac-arm-build branch February 10, 2023 16:43
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Fix default gn_build.sh on M1/M2 macs. (project-chip#24927)
99c508b 
* Fix default gn_build.sh on M1/M2 macs.

There is no "host clang" (i.e. pigweed clang) there.

Fixes project-chip#24609

* Address review comment.

* Fix k32w timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@LuDuda LuDuda LuDuda approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@mspang mspang Awaiting requested review from mspang

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
github gn review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Build error - missing pigweed libc++.a (M1 Ventura 13.1)
5 participants
@bzbarsky-apple @andy31415 @LuDuda @jmartinez-silabs @jtung-apple