-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster] Move unspecified thermostat types under the draft folder #24729
[cluster] Move unspecified thermostat types under the draft folder #24729
Conversation
2bc99f8
to
f0f49a1
Compare
PR #24729: Size comparison from 4f24db4 to 7f34883 Increases (9 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vivien-apple this seems to have sideffects on what gets generated in enums.h.
Is this expected? I assume if things compile we may not care, however at the same time our examples may not cover full functionality.
We can do whatever folks believe is the right thing to do. I choose to not include them in the generation process because they are currently unused and if one wants to enable them, it may requires to think twice. But If we believe those should still generates values in e |
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Problem
In #24694 I moved the thermostat related types/definitions to the
thermostat-cluster.xml
file to make it easier to see what exists and whatnot.But there is a lot of types in
types-silabs.xml
that are not specified and I also move some of them. To make sure those are not getting a cluster code or are misused liked I initially did in #24670 I have introduced adraft
folder in #24675 and I am planning to move all the things that are not specified there. So we keep them around, to not reproduce the ZCL work if they end up beeing specified, but it makes it clearer that those should not be used as if.This PR is an attempt to address #24694 (review)